-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(verification): move token info [part 2b/9] #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #858 +/- ##
==========================================
- Coverage 85.28% 85.27% -0.02%
==========================================
Files 281 281
Lines 22363 22364 +1
Branches 3388 3388
==========================================
- Hits 19073 19071 -2
Misses 2610 2610
- Partials 680 683 +3 ☔ View full report in Codecov by Sentry. |
glevco
force-pushed
the
refactor/verification-inheritance/2-verify-sum
branch
from
November 9, 2023 19:22
ba246bc
to
c69073d
Compare
glevco
force-pushed
the
refactor/move-token-info
branch
from
November 9, 2023 19:22
8cff879
to
a7635d4
Compare
glevco
force-pushed
the
refactor/verification-inheritance/2-verify-sum
branch
from
November 9, 2023 19:27
c69073d
to
2e709e9
Compare
glevco
force-pushed
the
refactor/move-token-info
branch
from
November 9, 2023 19:28
a7635d4
to
1bef803
Compare
This was referenced Nov 9, 2023
msbrogli
previously approved these changes
Nov 9, 2023
glevco
force-pushed
the
refactor/verification-inheritance/2-verify-sum
branch
2 times, most recently
from
November 10, 2023 16:31
dc55893
to
073d6f6
Compare
glevco
force-pushed
the
refactor/move-token-info
branch
from
November 10, 2023 16:56
1bef803
to
9857b55
Compare
glevco
changed the title
refactor: move token info
refactor(verification): move token info [part 2b/9]
Nov 10, 2023
1 task
glevco
force-pushed
the
refactor/verification-inheritance/2-verify-sum
branch
from
November 16, 2023 17:02
073d6f6
to
c084103
Compare
glevco
force-pushed
the
refactor/move-token-info
branch
from
November 16, 2023 17:03
9857b55
to
50171eb
Compare
Base automatically changed from
refactor/verification-inheritance/2-verify-sum
to
master
November 16, 2023 20:01
glevco
force-pushed
the
refactor/move-token-info
branch
from
November 16, 2023 20:03
50171eb
to
5693c13
Compare
msbrogli
approved these changes
Nov 16, 2023
jansegre
approved these changes
Nov 16, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #831
Motivation
During the verification refactors, some methods were moved from
Transaction
toTransactionVerifier
. Now that the refactors are complete (with PRs still to be merged), it's clear that those methods should be indeed inTransaction
, so they were moved back.Acceptance Criteria
update_token_info_from_outputs()
fromTransactionVerifier
toTransaction
, changing it to private.get_complete_token_info()
fromTransactionVerifier
toTransaction
.Transaction.get_token_info_from_inputs()
to private.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged