-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(verification): refactor verify_sum [part 2/9] #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
glevco
changed the title
refactor(verification): refactor verify_sum
refactor(verification): refactor verify_sum [part 2/9]
Oct 27, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #831 +/- ##
==========================================
- Coverage 85.28% 85.19% -0.09%
==========================================
Files 281 281
Lines 22354 22363 +9
Branches 3387 3388 +1
==========================================
- Hits 19065 19053 -12
- Misses 2608 2624 +16
- Partials 681 686 +5 ☔ View full report in Codecov by Sentry. |
msbrogli
requested changes
Nov 1, 2023
glevco
force-pushed
the
refactor/verification-inheritance/1-improvements
branch
3 times, most recently
from
November 7, 2023 16:22
99af497
to
50281e7
Compare
1 task
glevco
force-pushed
the
refactor/verification-inheritance/2-verify-sum
branch
from
November 7, 2023 21:20
6811073
to
005adad
Compare
glevco
force-pushed
the
refactor/verification-inheritance/1-improvements
branch
from
November 7, 2023 21:31
50281e7
to
c632ffe
Compare
glevco
force-pushed
the
refactor/verification-inheritance/2-verify-sum
branch
from
November 7, 2023 21:31
005adad
to
84f38ae
Compare
Base automatically changed from
refactor/verification-inheritance/1-improvements
to
master
November 7, 2023 22:26
glevco
force-pushed
the
refactor/verification-inheritance/2-verify-sum
branch
from
November 9, 2023 12:23
84f38ae
to
ba246bc
Compare
1 task
glevco
force-pushed
the
refactor/verification-inheritance/2-verify-sum
branch
2 times, most recently
from
November 9, 2023 19:27
c69073d
to
2e709e9
Compare
1 task
glevco
force-pushed
the
refactor/verification-inheritance/2-verify-sum
branch
2 times, most recently
from
November 10, 2023 16:31
dc55893
to
073d6f6
Compare
1 task
msbrogli
approved these changes
Nov 10, 2023
jansegre
approved these changes
Nov 16, 2023
glevco
force-pushed
the
refactor/verification-inheritance/2-verify-sum
branch
from
November 16, 2023 17:02
073d6f6
to
c084103
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #830
Motivation
Currently,
TokenCreationTransactionVerifier.verify_sum()
has duplicate code fromTransactionVerifier.verify_sum()
. This PR changes it so it calls the super method instead.Acceptance Criteria
TransactionVerifier.get_complete_token_info()
and update itsverify_sum()
to use it.TokenCreationTransaction.get_token_info_from_inputs()
, overriding theTransaction
implementation.TokenCreationTransaction.verify_sum()
to use the newget_complete_token_info()
.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged