Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(verification): remove VertexVerifier from BlockVerifier [part 7/9] #836

Merged

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Oct 27, 2023

Depends on #835

Motivation

Simplify code by removing the VertexVerifier composition from BlockVerifier.

Acceptance Criteria

  • Remove BlockVerifier.verify_outputs(), moving its only custom verification to a new verify_output_token_indexes() method, and moving its call to VerificationService._verify_without_storage_block(). This allows us to remove the VertexVerifier composition from BlockVerifier.
  • Update usages accordingly.
  • No behavior should be changed by this PR.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Oct 27, 2023
@glevco glevco changed the title refactor(verification): remove VertexVerifier from BlockVerifier refactor(verification): remove VertexVerifier from BlockVerifier [part 7/9] Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b5a3b8) 85.34% compared to head (7af542d) 85.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #836      +/-   ##
==========================================
- Coverage   85.34%   85.30%   -0.05%     
==========================================
  Files         283      283              
  Lines       22418    22416       -2     
  Branches     3397     3397              
==========================================
- Hits        19133    19121      -12     
- Misses       2602     2608       +6     
- Partials      683      687       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the refactor/verification-inheritance/6-remove-vertex-inheritance branch 2 times, most recently from f1553f4 to 738e2cb Compare November 10, 2023 19:07
@glevco glevco force-pushed the refactor/verification-inheritance/7-remove-vertex-block branch 2 times, most recently from ee1d52e to d0f42cc Compare November 10, 2023 19:17
@glevco glevco marked this pull request as ready for review November 10, 2023 20:04
@glevco glevco force-pushed the refactor/verification-inheritance/6-remove-vertex-inheritance branch from 738e2cb to 367093e Compare November 16, 2023 17:04
@glevco glevco force-pushed the refactor/verification-inheritance/7-remove-vertex-block branch from d0f42cc to 5ecf018 Compare November 16, 2023 17:05
@glevco glevco force-pushed the refactor/verification-inheritance/6-remove-vertex-inheritance branch from 367093e to 0dec101 Compare November 16, 2023 20:05
@glevco glevco force-pushed the refactor/verification-inheritance/7-remove-vertex-block branch from 5ecf018 to 45df1ef Compare November 16, 2023 20:06
@glevco glevco force-pushed the refactor/verification-inheritance/6-remove-vertex-inheritance branch from 0dec101 to b076a15 Compare November 16, 2023 21:25
@glevco glevco force-pushed the refactor/verification-inheritance/7-remove-vertex-block branch from 45df1ef to cbdf80b Compare November 16, 2023 21:26
@glevco glevco force-pushed the refactor/verification-inheritance/7-remove-vertex-block branch from cbdf80b to 21a6883 Compare November 27, 2023 20:23
@glevco glevco force-pushed the refactor/verification-inheritance/6-remove-vertex-inheritance branch from da25588 to 6e3e325 Compare November 29, 2023 02:14
@glevco glevco force-pushed the refactor/verification-inheritance/7-remove-vertex-block branch from 21a6883 to 2e7d25d Compare November 29, 2023 02:14
@glevco glevco force-pushed the refactor/verification-inheritance/6-remove-vertex-inheritance branch from 6e3e325 to 36aa21f Compare November 29, 2023 03:08
@glevco glevco force-pushed the refactor/verification-inheritance/7-remove-vertex-block branch from 2e7d25d to f7245f1 Compare November 29, 2023 03:09
Base automatically changed from refactor/verification-inheritance/6-remove-vertex-inheritance to master December 4, 2023 18:57
@glevco glevco force-pushed the refactor/verification-inheritance/7-remove-vertex-block branch from f7245f1 to 7af542d Compare December 5, 2023 14:33
@glevco glevco merged commit 353c6c4 into master Dec 6, 2023
9 checks passed
@glevco glevco deleted the refactor/verification-inheritance/7-remove-vertex-block branch December 6, 2023 17:04
@jansegre jansegre mentioned this pull request Dec 11, 2023
2 tasks
This was referenced Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants