-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(verification): remove VertexVerifier from BlockVerifier [part 7/9] #836
Merged
glevco
merged 1 commit into
master
from
refactor/verification-inheritance/7-remove-vertex-block
Dec 6, 2023
Merged
refactor(verification): remove VertexVerifier from BlockVerifier [part 7/9] #836
glevco
merged 1 commit into
master
from
refactor/verification-inheritance/7-remove-vertex-block
Dec 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
glevco
changed the title
refactor(verification): remove VertexVerifier from BlockVerifier
refactor(verification): remove VertexVerifier from BlockVerifier [part 7/9]
Oct 27, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #836 +/- ##
==========================================
- Coverage 85.34% 85.30% -0.05%
==========================================
Files 283 283
Lines 22418 22416 -2
Branches 3397 3397
==========================================
- Hits 19133 19121 -12
- Misses 2602 2608 +6
- Partials 683 687 +4 ☔ View full report in Codecov by Sentry. |
glevco
force-pushed
the
refactor/verification-inheritance/6-remove-vertex-inheritance
branch
2 times, most recently
from
November 10, 2023 19:07
f1553f4
to
738e2cb
Compare
glevco
force-pushed
the
refactor/verification-inheritance/7-remove-vertex-block
branch
2 times, most recently
from
November 10, 2023 19:17
ee1d52e
to
d0f42cc
Compare
glevco
force-pushed
the
refactor/verification-inheritance/6-remove-vertex-inheritance
branch
from
November 16, 2023 17:04
738e2cb
to
367093e
Compare
glevco
force-pushed
the
refactor/verification-inheritance/7-remove-vertex-block
branch
from
November 16, 2023 17:05
d0f42cc
to
5ecf018
Compare
glevco
force-pushed
the
refactor/verification-inheritance/6-remove-vertex-inheritance
branch
from
November 16, 2023 20:05
367093e
to
0dec101
Compare
glevco
force-pushed
the
refactor/verification-inheritance/7-remove-vertex-block
branch
from
November 16, 2023 20:06
5ecf018
to
45df1ef
Compare
glevco
force-pushed
the
refactor/verification-inheritance/6-remove-vertex-inheritance
branch
from
November 16, 2023 21:25
0dec101
to
b076a15
Compare
glevco
force-pushed
the
refactor/verification-inheritance/7-remove-vertex-block
branch
from
November 16, 2023 21:26
45df1ef
to
cbdf80b
Compare
glevco
force-pushed
the
refactor/verification-inheritance/7-remove-vertex-block
branch
from
November 27, 2023 20:23
cbdf80b
to
21a6883
Compare
glevco
force-pushed
the
refactor/verification-inheritance/6-remove-vertex-inheritance
branch
from
November 29, 2023 02:14
da25588
to
6e3e325
Compare
glevco
force-pushed
the
refactor/verification-inheritance/7-remove-vertex-block
branch
from
November 29, 2023 02:14
21a6883
to
2e7d25d
Compare
glevco
force-pushed
the
refactor/verification-inheritance/6-remove-vertex-inheritance
branch
from
November 29, 2023 03:08
6e3e325
to
36aa21f
Compare
glevco
force-pushed
the
refactor/verification-inheritance/7-remove-vertex-block
branch
from
November 29, 2023 03:09
2e7d25d
to
f7245f1
Compare
Base automatically changed from
refactor/verification-inheritance/6-remove-vertex-inheritance
to
master
December 4, 2023 18:57
glevco
force-pushed
the
refactor/verification-inheritance/7-remove-vertex-block
branch
from
December 5, 2023 14:33
f7245f1
to
7af542d
Compare
jansegre
approved these changes
Dec 5, 2023
msbrogli
approved these changes
Dec 6, 2023
glevco
deleted the
refactor/verification-inheritance/7-remove-vertex-block
branch
December 6, 2023 17:04
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #835
Motivation
Simplify code by removing the
VertexVerifier
composition fromBlockVerifier
.Acceptance Criteria
BlockVerifier.verify_outputs()
, moving its only custom verification to a newverify_output_token_indexes()
method, and moving its call toVerificationService._verify_without_storage_block()
. This allows us to remove theVertexVerifier
composition fromBlockVerifier
.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged