refactor(verification): remove VertexVerifier from TransactionVerifier [part 8/9] #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
glevco
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #837 +/- ##
==========================================
+ Coverage 85.25% 85.31% +0.05%
==========================================
Files 283 283
Lines 22416 22415 -1
Branches 3397 3397
==========================================
+ Hits 19111 19123 +12
+ Misses 2613 2606 -7
+ Partials 692 686 -6 ☔ View full report in Codecov by Sentry. |
glevco
force-pushed
the
refactor/verification-inheritance/7-remove-vertex-block
branch
2 times, most recently
from
ee1d52e to
d0f42cc
Compare
glevco
force-pushed
the
refactor/verification-inheritance/8-remove-vertex-tx
branch
from
edd0878 to
53a7f36
Compare
1 task
glevco
force-pushed
the
refactor/verification-inheritance/7-remove-vertex-block
branch
from
d0f42cc to
5ecf018
Compare
glevco
force-pushed
the
refactor/verification-inheritance/8-remove-vertex-tx
branch
from
53a7f36 to
cdc3256
Compare
glevco
force-pushed
the
refactor/verification-inheritance/7-remove-vertex-block
branch
from
5ecf018 to
45df1ef
Compare
glevco
force-pushed
the
refactor/verification-inheritance/8-remove-vertex-tx
branch
from
cdc3256 to
aaef3db
Compare
glevco
force-pushed
the
refactor/verification-inheritance/7-remove-vertex-block
branch
from
45df1ef to
cbdf80b
Compare
glevco
force-pushed
the
refactor/verification-inheritance/8-remove-vertex-tx
branch
from
aaef3db to
230e953
Compare
glevco
force-pushed
the
refactor/verification-inheritance/8-remove-vertex-tx
branch
from
230e953 to
b3974c0
Compare
glevco
force-pushed
the
refactor/verification-inheritance/7-remove-vertex-block
branch
from
21a6883 to
2e7d25d
Compare
glevco
force-pushed
the
refactor/verification-inheritance/8-remove-vertex-tx
branch
from
b3974c0 to
f5048ea
Compare
glevco
force-pushed
the
refactor/verification-inheritance/7-remove-vertex-block
branch
from
2e7d25d to
f7245f1
Compare
glevco
force-pushed
the
refactor/verification-inheritance/8-remove-vertex-tx
branch
from
f5048ea to
31630fd
Compare
glevco
force-pushed
the
refactor/verification-inheritance/7-remove-vertex-block
branch
from
f7245f1 to
7af542d
Compare
glevco
force-pushed
the
refactor/verification-inheritance/8-remove-vertex-tx
branch
from
31630fd to
9cd52aa
Compare
jansegre
previously approved these changes
Dec 5, 2023
msbrogli
previously approved these changes
Dec 6, 2023
Base automatically changed from
refactor/verification-inheritance/7-remove-vertex-block
to
master
December 6, 2023 17:04
glevco
dismissed stale reviews from msbrogli and jansegre
The base branch was changed.
glevco
force-pushed
the
refactor/verification-inheritance/8-remove-vertex-tx
branch
from
9cd52aa to
e21db39
Compare
jansegre
approved these changes
Dec 6, 2023
msbrogli
approved these changes
Dec 7, 2023
glevco
deleted the
refactor/verification-inheritance/8-remove-vertex-tx
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #836
Motivation
Simplify code by removing the
VertexVerifiercomposition fromTransactionVerifier.Acceptance Criteria
TransactionVerifier.verify_outputs(), moving its only custom verification to a newverify_output_token_indexes()method, and moving its call toVerificationService._verify_without_storage_tx(). This allows us to remove theVertexVerifiercomposition fromTransactionVerifier.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged