Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(verification): remove TransactionVerifier from TokenCreation… [part 9/9] #838

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Oct 27, 2023

Depends on #837

Motivation

What was the motivation for the changes in this PR?

Acceptance Criteria

  • Move TransactionVerifier's update_token_info_from_outputs() and get_complete_token_info() to Transaction.
  • Remove TransactionVerifier composition from TokenCreationTransactionVerifier, as it's not needed anymore.
  • Update usages accordingly.
  • No behavior should be changed by this PR.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Oct 27, 2023
@glevco glevco changed the title refactor(verification): remove TransactionVerifier from TokenCreation… refactor(verification): remove TransactionVerifier from TokenCreation… [part 4/9] Oct 27, 2023
@glevco glevco changed the title refactor(verification): remove TransactionVerifier from TokenCreation… [part 4/9] refactor(verification): remove TransactionVerifier from TokenCreation… [part 9/9] Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (edd0878) 84.57% compared to head (599708c) 84.61%.

Additional details and impacted files
@@                                   Coverage Diff                                    @@
##           refactor/verification-inheritance/8-remove-vertex-tx     #838      +/-   ##
========================================================================================
+ Coverage                                                 84.57%   84.61%   +0.03%     
========================================================================================
  Files                                                       271      271              
  Lines                                                     22305    22304       -1     
  Branches                                                   3404     3404              
========================================================================================
+ Hits                                                      18865    18872       +7     
+ Misses                                                     2768     2764       -4     
+ Partials                                                    672      668       -4     
Files Coverage Δ
hathor/transaction/token_creation_tx.py 99.20% <100.00%> (ø)
...erification/token_creation_transaction_verifier.py 100.00% <100.00%> (ø)
hathor/verification/transaction_verifier.py 92.38% <100.00%> (+0.44%) ⬆️
hathor/verification/vertex_verifiers.py 100.00% <100.00%> (ø)
hathor/transaction/transaction.py 94.31% <90.47%> (-0.46%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the refactor/verification-inheritance/8-remove-vertex-tx branch from edd0878 to 53a7f36 Compare November 10, 2023 19:23
@glevco glevco closed this Nov 10, 2023
@glevco glevco force-pushed the refactor/verification-inheritance/9-remove-tx-token branch from 599708c to 53a7f36 Compare November 10, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant