Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support for Python 3.12 #844

Merged
merged 1 commit into from
Jan 15, 2024
Merged

chore: add support for Python 3.12 #844

merged 1 commit into from
Jan 15, 2024

Conversation

jansegre
Copy link
Member

@jansegre jansegre commented Oct 30, 2023

Motivation

This Python release is out, there may not be specific features motivating the upgrade, but it's generally good to ensure everything is working on that version before we decide to use it.

Acceptance Criteria

  • Update CI to include Python 3.12
  • Update packages directly (pyproject.toml) or indirectly (poetry.lock) as needed
  • Avoid changes not needed to make it work

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre self-assigned this Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6c95fad) 0.00% compared to head (8e579c4) 85.21%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #844       +/-   ##
===========================================
+ Coverage        0   85.21%   +85.21%     
===========================================
  Files           0      285      +285     
  Lines           0    22370    +22370     
  Branches        0     3371     +3371     
===========================================
+ Hits            0    19063    +19063     
- Misses          0     2634     +2634     
- Partials        0      673      +673     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansegre jansegre force-pushed the chore/python-3.12 branch 2 times, most recently from e7b35d6 to bf1e946 Compare October 30, 2023 19:52
@jansegre jansegre changed the base branch from master to feat/shell-ipykernel January 12, 2024 17:47
@jansegre jansegre marked this pull request as ready for review January 12, 2024 17:47
@jansegre jansegre requested a review from msbrogli as a code owner January 12, 2024 17:47
@jansegre jansegre requested a review from glevco January 12, 2024 17:48
glevco
glevco previously approved these changes Jan 12, 2024
msbrogli
msbrogli previously approved these changes Jan 12, 2024
@jansegre jansegre force-pushed the feat/shell-ipykernel branch from c85ef3e to 2410024 Compare January 13, 2024 00:04
Base automatically changed from feat/shell-ipykernel to master January 15, 2024 16:05
@jansegre jansegre dismissed stale reviews from msbrogli and glevco January 15, 2024 16:05

The base branch was changed.

@jansegre jansegre merged commit 0ea7abb into master Jan 15, 2024
11 of 12 checks passed
@jansegre jansegre deleted the chore/python-3.12 branch January 15, 2024 17:27
@jansegre jansegre mentioned this pull request Jan 30, 2024
2 tasks
@jansegre jansegre mentioned this pull request Feb 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants