Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release-candidate v0.59.0-rc.1 #937

Merged
merged 33 commits into from
Jan 30, 2024
Merged

Release-candidate v0.59.0-rc.1 #937

merged 33 commits into from
Jan 30, 2024

Conversation

jansegre
Copy link
Member

@jansegre jansegre commented Jan 30, 2024

Changes

Checklist

jansegre and others added 30 commits December 26, 2023 13:24
feat(debug): make it possible to connect a remote ipython shell
…crese-evaluation-interval

feat(feature-activation): decrease mainnet evaluation interval to 1 week
…regression-on-windows

tests: fix CI regression on Windows + Python 3.10
@jansegre jansegre requested review from msbrogli and glevco January 30, 2024 16:01
@jansegre jansegre self-assigned this Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (7eab19b) 85.33% compared to head (d01aecc) 85.42%.
Report is 4 commits behind head on release-candidate.

❗ Current head d01aecc differs from pull request most recent head a8b7357. Consider uploading reports for the commit a8b7357 to get more accurate results

Files Patch % Lines
hathor/ipykernel.py 36.66% 19 Missing ⚠️
...n/storage/migrations/remove_second_nop_features.py 52.17% 11 Missing ⚠️
hathor/builder/cli_builder.py 33.33% 5 Missing and 1 partial ⚠️
...ons/add_feature_activation_bit_counts_metadata2.py 68.75% 5 Missing ⚠️
hathor/p2p/manager.py 81.25% 1 Missing and 2 partials ⚠️
hathor/manager.py 83.33% 0 Missing and 1 partial ⚠️
hathor/merged_mining/coordinator.py 0.00% 1 Missing ⚠️
...ions/add_feature_activation_bit_counts_metadata.py 0.00% 1 Missing ⚠️
...on/storage/migrations/remove_first_nop_features.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release-candidate     #937      +/-   ##
=====================================================
+ Coverage              85.33%   85.42%   +0.08%     
=====================================================
  Files                    284      290       +6     
  Lines                  22330    22454     +124     
  Branches                3367     3377      +10     
=====================================================
+ Hits                   19056    19181     +125     
- Misses                  2602     2610       +8     
+ Partials                 672      663       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

feat(cli): mark sync-v2 parameters as safe and deprecate --x-* ones
@jansegre jansegre marked this pull request as ready for review January 30, 2024 16:35
@jansegre jansegre merged commit f26bd2c into release-candidate Jan 30, 2024
24 of 26 checks passed
@jansegre jansegre mentioned this pull request Feb 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants