Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(settings): rename get_settings to get_global_settings #919

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Jan 8, 2024

Motivation

Rename the get_settings() function to get_global_settings() as requested in this comment: #768 (comment)

Acceptance Criteria

  • Rename the get_settings() function to get_global_settings().
  • No behavior should be changed.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco added the refactor label Jan 8, 2024
@glevco glevco self-assigned this Jan 8, 2024
@glevco glevco marked this pull request as ready for review January 8, 2024 20:51
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f5ef856) 85.23% compared to head (273d228) 85.29%.

Files Patch % Lines
...on/storage/migrations/remove_first_nop_features.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #919      +/-   ##
==========================================
+ Coverage   85.23%   85.29%   +0.06%     
==========================================
  Files         285      285              
  Lines       22370    22370              
  Branches     3371     3371              
==========================================
+ Hits        19066    19080      +14     
+ Misses       2633     2618      -15     
- Partials      671      672       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the refactor/rename-get-settings branch from 28d38c0 to b4fd2a2 Compare January 15, 2024 18:44
@glevco glevco force-pushed the refactor/rename-get-settings branch from b4fd2a2 to 273d228 Compare January 16, 2024 21:34
@glevco glevco merged commit 7e8ec09 into master Jan 16, 2024
12 checks passed
@glevco glevco deleted the refactor/rename-get-settings branch January 16, 2024 22:39
@jansegre jansegre mentioned this pull request Jan 30, 2024
2 tasks
@jansegre jansegre mentioned this pull request Feb 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants