Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix CI regression on Windows + Python 3.10 #926

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

jansegre
Copy link
Member

@jansegre jansegre commented Jan 16, 2024

Motivation

After #900 was merged it looks like the CI broke on Windows + Python 3.10 because when running a certain test that expects to reach Python's recursion limit, it will stack overflow instead. The reason why it happens is unclear, but since it's for a test that tests such a specific limit, it is better to adapt the test instead.

Acceptance Criteria

  • Improve the test to use setUp/tearDown to temporarily decrease the recursion limit (arbitrarily to 100, because it's enough, instead of the default that is usually 1000);

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre self-assigned this Jan 16, 2024
@jansegre jansegre requested a review from msbrogli as a code owner January 16, 2024 00:43
@jansegre jansegre requested a review from glevco January 16, 2024 00:43
glevco
glevco previously approved these changes Jan 16, 2024
@jansegre jansegre force-pushed the tests/fix-recursion-limit-regression-on-windows branch from da8a255 to d29d503 Compare January 16, 2024 01:11
@jansegre jansegre force-pushed the tests/fix-recursion-limit-regression-on-windows branch from d29d503 to 9cf7d79 Compare January 16, 2024 01:13
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6448f56) 85.23% compared to head (9cf7d79) 85.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #926   +/-   ##
=======================================
  Coverage   85.23%   85.24%           
=======================================
  Files         285      285           
  Lines       22370    22370           
  Branches     3371     3371           
=======================================
+ Hits        19068    19069    +1     
- Misses       2630     2632    +2     
+ Partials      672      669    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansegre jansegre merged commit f5ef856 into master Jan 16, 2024
12 checks passed
@jansegre jansegre deleted the tests/fix-recursion-limit-regression-on-windows branch January 16, 2024 15:34
@jansegre jansegre mentioned this pull request Jan 30, 2024
2 tasks
@jansegre jansegre mentioned this pull request Feb 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants