Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The test for maximum line length in the P2P protocol is not correctly testing what it is supposed to. Currently, it checks whether the protocol is disconnecting, which happens even if the payload is smaller than the max length. Also, the size of the test payload was way larger than the actual limit. We should test the edges, 1 byte short.
Acceptance Criteria
test_invalid_size()
.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged