Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feature-activation): update NOP features config on mainnet #929

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Jan 19, 2024

Motivation

The start_height of NOP_FEATURE_2 is not correct.

Acceptance Criteria

  • Fix the NOP features config on mainnet.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Jan 19, 2024
@glevco glevco marked this pull request as ready for review January 19, 2024 01:39
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a43a05) 85.38% compared to head (459d3fc) 85.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #929      +/-   ##
==========================================
- Coverage   85.38%   85.26%   -0.12%     
==========================================
  Files         285      285              
  Lines       22365    22365              
  Branches     3369     3369              
==========================================
- Hits        19096    19070      -26     
- Misses       2601     2621      +20     
- Partials      668      674       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco merged commit ded4c79 into master Jan 19, 2024
12 checks passed
@glevco glevco deleted the feat/feature-activation/mainnet-nop-features branch January 19, 2024 16:22
@jansegre jansegre mentioned this pull request Jan 30, 2024
2 tasks
@jansegre jansegre mentioned this pull request Feb 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants