Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(event): fix missing hash update #921

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

jansegre
Copy link
Member

Motivation

This inconsistency was noticed when testing an upgrade to Python 3.12, it's unclear why the test was passing though.

Acceptance Criteria

  • Make sure block's hash is updated after altering its parents.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre self-assigned this Jan 10, 2024
@jansegre jansegre requested a review from msbrogli as a code owner January 10, 2024 16:08
@jansegre jansegre requested a review from glevco January 10, 2024 16:14
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (abbd054) 85.26% compared to head (109ffc7) 85.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #921      +/-   ##
==========================================
+ Coverage   85.26%   85.33%   +0.07%     
==========================================
  Files         284      284              
  Lines       22330    22332       +2     
  Branches     3367     3368       +1     
==========================================
+ Hits        19039    19058      +19     
+ Misses       2616     2606      -10     
+ Partials      675      668       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansegre jansegre merged commit 9b1bbcc into master Jan 11, 2024
9 checks passed
@jansegre jansegre deleted the tests/fix-missing-hash-update branch January 11, 2024 23:46
@jansegre jansegre mentioned this pull request Jan 30, 2024
2 tasks
@jansegre jansegre mentioned this pull request Feb 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants