Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(events): fix events simulator CLI #907

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Dec 29, 2023

Motivation

The events simulator CLI is not working.

Acceptance Criteria

  • Fix import problem in events simulator CLI and add a test for it.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco added the bug Something isn't working label Dec 29, 2023
@glevco glevco self-assigned this Dec 29, 2023
@glevco glevco marked this pull request as ready for review December 29, 2023 15:55
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c0364ba) 85.31% compared to head (481d3fe) 85.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #907      +/-   ##
==========================================
- Coverage   85.31%   85.25%   -0.07%     
==========================================
  Files         284      284              
  Lines       22330    22330              
  Branches     3367     3367              
==========================================
- Hits        19051    19037      -14     
- Misses       2605     2616      +11     
- Partials      674      677       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco merged commit 126bae3 into master Dec 29, 2023
9 checks passed
@glevco glevco deleted the fix/events-simulator branch December 29, 2023 16:40
@jansegre jansegre mentioned this pull request Jan 30, 2024
2 tasks
@jansegre jansegre mentioned this pull request Feb 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants