Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(feature-activation): improve phased testing logs #905

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Dec 27, 2023

Motivation

During the Feature Activation Phased Testing on testnet, we noticed that logs were missing the block hash, which makes it harder to search for specific logs.

Acceptance Criteria

  • Add block hash to Feature Activation Phased Testing logs.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Dec 27, 2023
@glevco glevco marked this pull request as ready for review December 27, 2023 16:21
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7eab19b) 85.33% compared to head (e150b11) 85.32%.

Files Patch % Lines
hathor/manager.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #905      +/-   ##
==========================================
- Coverage   85.33%   85.32%   -0.01%     
==========================================
  Files         284      284              
  Lines       22330    22330              
  Branches     3367     3367              
==========================================
- Hits        19056    19054       -2     
- Misses       2602     2606       +4     
+ Partials      672      670       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco merged commit 0040f51 into master Dec 27, 2023
9 checks passed
@glevco glevco deleted the chore/feature-activation-logging branch December 27, 2023 18:29
@jansegre jansegre mentioned this pull request Jan 30, 2024
2 tasks
@jansegre jansegre mentioned this pull request Feb 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants