Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(merged-mining): configure new max merkle path length on testnet #910

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Jan 5, 2024

Depends on #931

Motivation

Create a new feature to change the maximum merkle path length of merged mining through Feature Activation, and configure it on testnet to start the process in roughly two weeks.

Acceptance Criteria

  • Create INCREASE_MAX_MERKLE_PATH_LENGTH feature and configure it on testnet.
  • Change BitcoinAuxPow.verify to receive a max_merkle_path_length instead of using a constant.
  • Change MergeMinedBlockVerifier.verify_aux_pow to use Feature Activation to determine the max_merkle_path_length.
  • Update tests.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Jan 5, 2024
@glevco glevco force-pushed the feat/new-max-merkle-path-length branch from a183ad4 to 4f286f1 Compare January 6, 2024 01:12
hathor/transaction/aux_pow.py Outdated Show resolved Hide resolved
@glevco glevco marked this pull request as ready for review January 6, 2024 01:23
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (b6748ee) 85.37% compared to head (a9a643d) 85.30%.
Report is 1 commits behind head on master.

Files Patch % Lines
...n/storage/migrations/remove_second_nop_features.py 52.17% 11 Missing ⚠️
hathor/merged_mining/coordinator.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #910      +/-   ##
==========================================
- Coverage   85.37%   85.30%   -0.07%     
==========================================
  Files         289      290       +1     
  Lines       22416    22454      +38     
  Branches     3374     3377       +3     
==========================================
+ Hits        19138    19155      +17     
- Misses       2608     2627      +19     
- Partials      670      672       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hathor/transaction/aux_pow.py Outdated Show resolved Hide resolved
hathor/transaction/aux_pow.py Outdated Show resolved Hide resolved
hathor/verification/merge_mined_block_verifier.py Outdated Show resolved Hide resolved
jansegre
jansegre previously approved these changes Jan 8, 2024
@glevco glevco force-pushed the feat/feature-activation/remove-enable-usage branch from 27a2baf to 470de39 Compare January 9, 2024 15:04
@glevco glevco force-pushed the feat/new-max-merkle-path-length branch from f4b6182 to 548f1a4 Compare January 9, 2024 15:05
@glevco glevco force-pushed the feat/feature-activation/remove-enable-usage branch from 470de39 to 12992a0 Compare January 12, 2024 16:03
@glevco glevco force-pushed the feat/new-max-merkle-path-length branch from 548f1a4 to 5107413 Compare January 12, 2024 16:04
hathor/conf/testnet.yml Outdated Show resolved Hide resolved
msbrogli
msbrogli previously approved these changes Jan 12, 2024
hathor/merged_mining/coordinator.py Outdated Show resolved Hide resolved
@glevco glevco force-pushed the feat/feature-activation/remove-enable-usage branch from 12992a0 to 7e2e3ee Compare January 15, 2024 18:43
@glevco glevco marked this pull request as draft January 16, 2024 02:08
@glevco glevco force-pushed the feat/feature-activation/remove-enable-usage branch 2 times, most recently from 522a33e to 67326fd Compare January 19, 2024 17:24
Base automatically changed from feat/feature-activation/remove-enable-usage to master January 19, 2024 19:00
@glevco glevco dismissed stale reviews from msbrogli and jansegre January 19, 2024 19:00

The base branch was changed.

@glevco glevco force-pushed the feat/new-max-merkle-path-length branch from 5107413 to b520502 Compare January 23, 2024 00:42
@glevco glevco changed the base branch from master to chore/feature-activation/testnet-adjustments January 23, 2024 00:43
@glevco glevco marked this pull request as ready for review January 23, 2024 01:02
jansegre
jansegre previously approved these changes Jan 23, 2024
msbrogli
msbrogli previously approved these changes Jan 25, 2024
hathor/conf/testnet.py Outdated Show resolved Hide resolved
hathor/feature_activation/feature.py Show resolved Hide resolved
hathor/transaction/aux_pow.py Show resolved Hide resolved
hathor/transaction/aux_pow.py Show resolved Hide resolved
@glevco glevco force-pushed the chore/feature-activation/testnet-adjustments branch from 5029a38 to bc3dfca Compare January 29, 2024 03:22
@glevco glevco force-pushed the feat/new-max-merkle-path-length branch from 863db2a to 87defee Compare January 29, 2024 17:46
Base automatically changed from chore/feature-activation/testnet-adjustments to master January 30, 2024 04:48
@glevco glevco dismissed stale reviews from msbrogli and jansegre January 30, 2024 04:48

The base branch was changed.

@glevco glevco force-pushed the feat/new-max-merkle-path-length branch from 87defee to a44fdfe Compare January 30, 2024 04:51
@glevco glevco force-pushed the feat/new-max-merkle-path-length branch from a44fdfe to a9a643d Compare January 30, 2024 04:51
@jansegre jansegre merged commit d01aecc into master Jan 30, 2024
11 of 12 checks passed
@jansegre jansegre deleted the feat/new-max-merkle-path-length branch January 30, 2024 11:19
@jansegre jansegre mentioned this pull request Jan 30, 2024
2 tasks
@jansegre jansegre mentioned this pull request Feb 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants