-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(merged-mining): configure new max merkle path length on testnet #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
force-pushed
the
feat/new-max-merkle-path-length
branch
from
January 6, 2024 01:12
a183ad4
to
4f286f1
Compare
glevco
commented
Jan 6, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #910 +/- ##
==========================================
- Coverage 85.37% 85.30% -0.07%
==========================================
Files 289 290 +1
Lines 22416 22454 +38
Branches 3374 3377 +3
==========================================
+ Hits 19138 19155 +17
- Misses 2608 2627 +19
- Partials 670 672 +2 ☔ View full report in Codecov by Sentry. |
jansegre
requested changes
Jan 8, 2024
jansegre
previously approved these changes
Jan 8, 2024
glevco
force-pushed
the
feat/feature-activation/remove-enable-usage
branch
from
January 9, 2024 15:04
27a2baf
to
470de39
Compare
glevco
force-pushed
the
feat/new-max-merkle-path-length
branch
from
January 9, 2024 15:05
f4b6182
to
548f1a4
Compare
glevco
force-pushed
the
feat/feature-activation/remove-enable-usage
branch
from
January 12, 2024 16:03
470de39
to
12992a0
Compare
glevco
force-pushed
the
feat/new-max-merkle-path-length
branch
from
January 12, 2024 16:04
548f1a4
to
5107413
Compare
glevco
commented
Jan 12, 2024
msbrogli
previously approved these changes
Jan 12, 2024
glevco
force-pushed
the
feat/feature-activation/remove-enable-usage
branch
from
January 15, 2024 18:43
12992a0
to
7e2e3ee
Compare
glevco
force-pushed
the
feat/feature-activation/remove-enable-usage
branch
2 times, most recently
from
January 19, 2024 17:24
522a33e
to
67326fd
Compare
Base automatically changed from
feat/feature-activation/remove-enable-usage
to
master
January 19, 2024 19:00
glevco
dismissed stale reviews from msbrogli and jansegre
January 19, 2024 19:00
The base branch was changed.
glevco
force-pushed
the
feat/new-max-merkle-path-length
branch
from
January 23, 2024 00:42
5107413
to
b520502
Compare
glevco
changed the base branch from
master
to
chore/feature-activation/testnet-adjustments
January 23, 2024 00:43
jansegre
previously approved these changes
Jan 23, 2024
msbrogli
previously approved these changes
Jan 25, 2024
glevco
force-pushed
the
chore/feature-activation/testnet-adjustments
branch
from
January 29, 2024 03:22
5029a38
to
bc3dfca
Compare
glevco
force-pushed
the
feat/new-max-merkle-path-length
branch
from
January 29, 2024 17:46
863db2a
to
87defee
Compare
4 tasks
Base automatically changed from
chore/feature-activation/testnet-adjustments
to
master
January 30, 2024 04:48
glevco
dismissed stale reviews from msbrogli and jansegre
January 30, 2024 04:48
The base branch was changed.
glevco
force-pushed
the
feat/new-max-merkle-path-length
branch
from
January 30, 2024 04:51
87defee
to
a44fdfe
Compare
glevco
force-pushed
the
feat/new-max-merkle-path-length
branch
from
January 30, 2024 04:51
a44fdfe
to
a9a643d
Compare
msbrogli
approved these changes
Jan 30, 2024
jansegre
approved these changes
Jan 30, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #931
Motivation
Create a new feature to change the maximum merkle path length of merged mining through Feature Activation, and configure it on testnet to start the process in roughly two weeks.
Acceptance Criteria
INCREASE_MAX_MERKLE_PATH_LENGTH
feature and configure it on testnet.BitcoinAuxPow.verify
to receive amax_merkle_path_length
instead of using a constant.MergeMinedBlockVerifier.verify_aux_pow
to use Feature Activation to determine themax_merkle_path_length
.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged