Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(feature-activation): remove enable_usage #909

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Jan 5, 2024

Depends on #908

Motivation

Since Feature Activation was enabled on mainnet on the previous PR, we can now remove the enable_usage setting, as its only purpose was making Feature Activation available on testnet but not mainnet.

Acceptance Criteria

  • Make FeatureService mandatory on VertexVerifiers.
  • Remove enable_usage property from Feature Activation settings, and update code accordingly.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Jan 5, 2024
@glevco glevco added the refactor label Jan 5, 2024
@glevco glevco force-pushed the feat/feature-activation/remove-enable-usage branch from 0195a02 to 27a2baf Compare January 5, 2024 23:47
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ded4c79) 85.30% compared to head (67326fd) 85.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #909      +/-   ##
==========================================
- Coverage   85.30%   85.21%   -0.09%     
==========================================
  Files         285      285              
  Lines       22365    22361       -4     
  Branches     3369     3368       -1     
==========================================
- Hits        19078    19056      -22     
- Misses       2612     2627      +15     
- Partials      675      678       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco marked this pull request as ready for review January 6, 2024 01:23
jansegre
jansegre previously approved these changes Jan 8, 2024
@glevco glevco force-pushed the feat/feature-activation/mainnet-nop-features branch from 815eb6f to 7077f40 Compare January 9, 2024 15:03
@glevco glevco force-pushed the feat/feature-activation/remove-enable-usage branch from 27a2baf to 470de39 Compare January 9, 2024 15:04
@glevco glevco force-pushed the feat/feature-activation/mainnet-nop-features branch from 7077f40 to a37fdb8 Compare January 12, 2024 15:56
@glevco glevco force-pushed the feat/feature-activation/remove-enable-usage branch from 470de39 to 12992a0 Compare January 12, 2024 16:03
msbrogli
msbrogli previously approved these changes Jan 12, 2024
@glevco glevco force-pushed the feat/feature-activation/mainnet-nop-features branch from 64d0a86 to 47d61df Compare January 15, 2024 18:42
@glevco glevco force-pushed the feat/feature-activation/remove-enable-usage branch from 12992a0 to 7e2e3ee Compare January 15, 2024 18:43
@glevco glevco force-pushed the feat/feature-activation/mainnet-nop-features branch 3 times, most recently from 1c69286 to 58f40ab Compare January 18, 2024 23:38
Base automatically changed from feat/feature-activation/mainnet-nop-features to master January 19, 2024 01:18
@glevco glevco dismissed stale reviews from msbrogli and jansegre January 19, 2024 01:18

The base branch was changed.

@glevco glevco force-pushed the feat/feature-activation/remove-enable-usage branch from 7e2e3ee to 522a33e Compare January 19, 2024 01:47
@glevco glevco force-pushed the feat/feature-activation/remove-enable-usage branch from 522a33e to 67326fd Compare January 19, 2024 17:24
@glevco glevco merged commit a653335 into master Jan 19, 2024
12 checks passed
@glevco glevco deleted the feat/feature-activation/remove-enable-usage branch January 19, 2024 19:00
@jansegre jansegre mentioned this pull request Jan 30, 2024
2 tasks
@jansegre jansegre mentioned this pull request Feb 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants