-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(feature-activation): remove enable_usage #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
force-pushed
the
feat/feature-activation/remove-enable-usage
branch
from
January 5, 2024 23:47
0195a02
to
27a2baf
Compare
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #909 +/- ##
==========================================
- Coverage 85.30% 85.21% -0.09%
==========================================
Files 285 285
Lines 22365 22361 -4
Branches 3369 3368 -1
==========================================
- Hits 19078 19056 -22
- Misses 2612 2627 +15
- Partials 675 678 +3 ☔ View full report in Codecov by Sentry. |
jansegre
previously approved these changes
Jan 8, 2024
glevco
force-pushed
the
feat/feature-activation/mainnet-nop-features
branch
from
January 9, 2024 15:03
815eb6f
to
7077f40
Compare
glevco
force-pushed
the
feat/feature-activation/remove-enable-usage
branch
from
January 9, 2024 15:04
27a2baf
to
470de39
Compare
1 task
glevco
force-pushed
the
feat/feature-activation/mainnet-nop-features
branch
from
January 12, 2024 15:56
7077f40
to
a37fdb8
Compare
glevco
force-pushed
the
feat/feature-activation/remove-enable-usage
branch
from
January 12, 2024 16:03
470de39
to
12992a0
Compare
msbrogli
previously approved these changes
Jan 12, 2024
glevco
force-pushed
the
feat/feature-activation/mainnet-nop-features
branch
from
January 15, 2024 18:42
64d0a86
to
47d61df
Compare
glevco
force-pushed
the
feat/feature-activation/remove-enable-usage
branch
from
January 15, 2024 18:43
12992a0
to
7e2e3ee
Compare
glevco
force-pushed
the
feat/feature-activation/mainnet-nop-features
branch
3 times, most recently
from
January 18, 2024 23:38
1c69286
to
58f40ab
Compare
Base automatically changed from
feat/feature-activation/mainnet-nop-features
to
master
January 19, 2024 01:18
glevco
dismissed stale reviews from msbrogli and jansegre
January 19, 2024 01:18
The base branch was changed.
glevco
force-pushed
the
feat/feature-activation/remove-enable-usage
branch
from
January 19, 2024 01:47
7e2e3ee
to
522a33e
Compare
glevco
force-pushed
the
feat/feature-activation/remove-enable-usage
branch
from
January 19, 2024 17:24
522a33e
to
67326fd
Compare
jansegre
approved these changes
Jan 19, 2024
msbrogli
approved these changes
Jan 19, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #908
Motivation
Since Feature Activation was enabled on mainnet on the previous PR, we can now remove the
enable_usage
setting, as its only purpose was making Feature Activation available on testnet but not mainnet.Acceptance Criteria
FeatureService
mandatory onVertexVerifiers
.enable_usage
property from Feature Activation settings, and update code accordingly.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged