-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(daa): externalize block dependencies #895
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
force-pushed
the
refactor/daa-dependencies
branch
2 times, most recently
from
December 14, 2023 21:26
3444e20
to
869420e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #895 +/- ##
==========================================
+ Coverage 85.02% 85.16% +0.14%
==========================================
Files 294 295 +1
Lines 22801 22864 +63
Branches 3435 3443 +8
==========================================
+ Hits 19386 19472 +86
+ Misses 2726 2710 -16
+ Partials 689 682 -7 ☔ View full report in Codecov by Sentry. |
glevco
force-pushed
the
refactor/daa-dependencies
branch
2 times, most recently
from
December 19, 2023 18:26
d4b1031
to
d7f0dd3
Compare
glevco
force-pushed
the
refactor/daa-dependencies
branch
5 times, most recently
from
December 22, 2023 16:24
5bb8188
to
aeb3005
Compare
glevco
commented
Dec 22, 2023
glevco
force-pushed
the
refactor/daa-dependencies
branch
2 times, most recently
from
December 22, 2023 17:23
b64479b
to
289059e
Compare
1 task
msbrogli
requested changes
Dec 26, 2023
glevco
force-pushed
the
refactor/daa-dependencies
branch
from
December 27, 2023 18:19
289059e
to
c4aa2b8
Compare
glevco
force-pushed
the
refactor/daa-dependencies
branch
2 times, most recently
from
January 9, 2024 15:06
e774d52
to
103162b
Compare
glevco
changed the base branch from
master
to
feat/feature-activation/remove-enable-usage
January 9, 2024 21:54
glevco
force-pushed
the
feat/feature-activation/remove-enable-usage
branch
3 times, most recently
from
January 19, 2024 01:47
7e2e3ee
to
522a33e
Compare
glevco
force-pushed
the
feat/feature-activation/remove-enable-usage
branch
from
January 19, 2024 17:24
522a33e
to
67326fd
Compare
Base automatically changed from
feat/feature-activation/remove-enable-usage
to
master
January 19, 2024 19:00
glevco
force-pushed
the
refactor/daa-dependencies
branch
from
January 23, 2024 02:58
103162b
to
204fa2c
Compare
jansegre
approved these changes
Feb 1, 2024
glevco
force-pushed
the
refactor/daa-dependencies
branch
from
March 5, 2024 16:03
204fa2c
to
b895832
Compare
msbrogli
approved these changes
Mar 21, 2024
glevco
force-pushed
the
refactor/daa-dependencies
branch
2 times, most recently
from
March 21, 2024 21:18
5a1aaf6
to
7eb1d79
Compare
glevco
force-pushed
the
refactor/daa-dependencies
branch
from
March 22, 2024 15:57
7eb1d79
to
ae05d01
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #909
Motivation
Change the DAA so it does not access the storage directly. Instead, block verification can pass pre-fetched dependencies through a new
SimpleMemoryStorage
. This will be useful for Multiprocess Verification.Acceptance Criteria
SimpleMemoryStorage
class that will be used for storing pre-fetched verification dependencies in memory.calculate_block_difficulty
andcalculate_next_weight
to accept aSimpleMemoryStorage
, which is used to retrieve pre-fetched parent blocks.verify_weight
to pre-fetch DAA dependencies.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged