Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feature-activation): decrease mainnet evaluation interval to 1 week #903

Merged

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Dec 21, 2023

Motivation

Decrease the Feature Activation Evaluation Interval from 2 weeks to 1 week, to decrease the time to release new features.

Acceptance Criteria

  • Change the default Feature Activation settings value of Evaluation Interval from 2 weeks to 1 week.
  • Update the testnet Evaluation Interval value to keep it 2 weeks (this is necessary since we're currently running tests on testnet, but after that, we can also use 1 week for testnet).

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8e579c4) 85.21% compared to head (1b2b955) 85.27%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #903      +/-   ##
==========================================
+ Coverage   85.21%   85.27%   +0.06%     
==========================================
  Files         285      285              
  Lines       22370    22370              
  Branches     3371     3371              
==========================================
+ Hits        19063    19077      +14     
+ Misses       2634     2623      -11     
+ Partials      673      670       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco marked this pull request as ready for review December 22, 2023 15:36
@glevco glevco force-pushed the feat/feature-activation/decrese-evaluation-interval branch from 6fe66f4 to e4235bf Compare January 2, 2024 16:49
@glevco glevco force-pushed the feat/feature-activation/decrese-evaluation-interval branch 2 times, most recently from 974b7e2 to 7904143 Compare January 12, 2024 15:55
@glevco glevco force-pushed the feat/feature-activation/decrese-evaluation-interval branch from 7904143 to 1b2b955 Compare January 15, 2024 18:41
@jansegre jansegre merged commit 6448f56 into master Jan 16, 2024
11 of 12 checks passed
@jansegre jansegre deleted the feat/feature-activation/decrese-evaluation-interval branch January 16, 2024 00:31
@jansegre jansegre mentioned this pull request Jan 30, 2024
2 tasks
@jansegre jansegre mentioned this pull request Feb 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants