-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(feature-activation): implement bit signaling sysctl #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
force-pushed
the
feat/feature-activation/sysctl
branch
from
February 27, 2024 22:57
bdf3a43
to
139577d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #962 +/- ##
===========================================
+ Coverage 0 85.04% +85.04%
===========================================
Files 0 296 +296
Lines 0 22918 +22918
Branches 0 3451 +3451
===========================================
+ Hits 0 19490 +19490
- Misses 0 2741 +2741
- Partials 0 687 +687 ☔ View full report in Codecov by Sentry. |
This was referenced Feb 29, 2024
msbrogli
requested changes
Mar 1, 2024
glevco
force-pushed
the
feat/feature-activation/sysctl
branch
2 times, most recently
from
March 21, 2024 21:32
3ef4d62
to
be9a2de
Compare
jansegre
approved these changes
Mar 22, 2024
jansegre
approved these changes
Mar 22, 2024
msbrogli
approved these changes
Apr 2, 2024
glevco
force-pushed
the
feat/feature-activation/sysctl
branch
from
April 2, 2024 17:01
be9a2de
to
8a864eb
Compare
glevco
force-pushed
the
feat/feature-activation/sysctl
branch
from
April 2, 2024 17:01
8a864eb
to
4b44a2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add sysctl commands to control Feature Activation bit signaling without having to restart the full node (previously, this was only available through CLI options). The commands are the following:
core.features.supported_features
Return features that are explicitly enabled. Read-only.
core.features.not_supported_features
Return features that are explicitly disabled. Read-only.
core.features.signaling_features
Return which feature are currently in a signaling phase. Read-only.
core.features.add_support
Add support for a feature. Write-only.
core.features.remove_support
Remove support for a feature. Write-only.
Example
Then, the bits in the block template will be changed accordingly.
Acceptance Criteria
core.features
sysctl command group with the following subcommands:supported_features
,not_supported_features
,signaling_features
,add_support
, andremove_support
.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged