feat(feature-activation): automatically enable support in MUST_SIGNAL #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #963 +/- ##
==========================================
+ Coverage 85.04% 85.10% +0.06%
==========================================
Files 296 296
Lines 22918 22925 +7
Branches 3451 3452 +1
==========================================
+ Hits 19491 19511 +20
+ Misses 2740 2728 -12
+ Partials 687 686 -1 ☔ View full report in Codecov by Sentry. |
msbrogli
requested changes
Mar 1, 2024
glevco
force-pushed
the
feat/feature-activation/sysctl
branch
2 times, most recently
from
3ef4d62 to
be9a2de
Compare
glevco
force-pushed
the
feat/feature-activation/enable-when-must-signal
branch
from
6c43590 to
5086127
Compare
msbrogli
previously approved these changes
Mar 22, 2024
jansegre
previously approved these changes
Mar 22, 2024
glevco
force-pushed
the
feat/feature-activation/sysctl
branch
2 times, most recently
from
8a864eb to
4b44a2a
Compare
glevco
dismissed stale reviews from jansegre and msbrogli
The base branch was changed.
glevco
force-pushed
the
feat/feature-activation/enable-when-must-signal
branch
from
ed8023e to
826dc0c
Compare
jansegre
approved these changes
Apr 2, 2024
msbrogli
approved these changes
Apr 2, 2024
glevco
force-pushed
the
feat/feature-activation/enable-when-must-signal
branch
from
826dc0c to
9efd25e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #962
Motivation
For updated nodes, when a feature reaches the
MUST_SIGNALphase, the node will automatically enable the feature's bit signaling, unless explicitly removed via the CLI or Sysctl tools.Acceptance Criteria
BitSignalingService.on_must_signal().FeatureServiceto callon_must_signal().Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged