refactor(mypy): add stricter rules to some test modules [part II/VI] #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
glevco
force-pushed
the
refactor/strict-mypy-2
branch
2 times, most recently
from
59dba5c to
7fb6b30
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #971 +/- ##
==========================================
- Coverage 85.10% 85.09% -0.02%
==========================================
Files 294 294
Lines 22797 22798 +1
Branches 3434 3434
==========================================
- Hits 19402 19400 -2
- Misses 2710 2712 +2
- Partials 685 686 +1 ☔ View full report in Codecov by Sentry. |
glevco
changed the title
glevco
changed the title
msbrogli
previously approved these changes
Mar 19, 2024
glevco
force-pushed
the
refactor/strict-mypy
branch
from
27011cb to
0f107df
Compare
glevco
force-pushed
the
refactor/strict-mypy-2
branch
from
7fb6b30 to
edd547e
Compare
glevco
force-pushed
the
refactor/strict-mypy
branch
from
0f107df to
0d3deb6
Compare
glevco
force-pushed
the
refactor/strict-mypy-2
branch
from
eea7f83 to
0fafa35
Compare
msbrogli
previously approved these changes
Mar 19, 2024
jansegre
previously approved these changes
Mar 19, 2024
glevco
dismissed stale reviews from jansegre and msbrogli
The merge-base changed after approval.
glevco
force-pushed
the
refactor/strict-mypy-2
branch
from
0fafa35 to
6613e62
Compare
msbrogli
approved these changes
Mar 20, 2024
jansegre
approved these changes
Mar 20, 2024
glevco
force-pushed
the
refactor/strict-mypy-2
branch
from
2c62ee4 to
189f48c
Compare
glevco
force-pushed
the
refactor/strict-mypy-2
branch
from
189f48c to
a9219d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #969
Motivation
This PR continues to improve the strictness of mypy in test modules. For more info see the previous PR, #969.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged