-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(mypy): add stricter rules to specific modules [part I/VI] #969
Conversation
43eb06d
to
5916646
Compare
0bc534b
to
27011cb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #969 +/- ##
==========================================
+ Coverage 85.12% 85.15% +0.02%
==========================================
Files 294 294
Lines 22783 22789 +6
Branches 3430 3432 +2
==========================================
+ Hits 19395 19405 +10
+ Misses 2707 2703 -4
Partials 681 681 ☔ View full report in Codecov by Sentry. |
5916646
to
6c494e6
Compare
27011cb
to
0f107df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
The base branch was changed.
0f107df
to
0d3deb6
Compare
Depends on #967
Motivation
We currently use a subset of static typing rules with mypy, for historic reasons. The aim should be to enable
strict=True
in the whole repo, or at least most of it. One way to do this incrementally is to configure a mypy override with stricter rules and set it for some specific modules.This PR does this for some newer or important modules. We cannot use
strict=True
directly, because this rule is not available on per-module configs. Therefore, we get all strict rules from the mypy documentation and manually configure them.Acceptance Criteria
mypy
andmypy-zope
.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged