refactor(mypy): add stricter rules to unittest and utils [part V/VI] #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #974 +/- ##
==========================================
- Coverage 85.10% 85.03% -0.07%
==========================================
Files 295 295
Lines 22864 22864
Branches 3443 3443
==========================================
- Hits 19459 19443 -16
- Misses 2720 2729 +9
- Partials 685 692 +7 ☔ View full report in Codecov by Sentry. |
glevco
changed the title
glevco
force-pushed
the
refactor/strict-mypy-4
branch
from
5235577 to
ef291c0
Compare
glevco
force-pushed
the
refactor/strict-mypy-5
branch
from
587695c to
f9b553d
Compare
msbrogli
previously approved these changes
Mar 19, 2024
glevco
force-pushed
the
refactor/strict-mypy-4
branch
from
ef291c0 to
1a1d5c8
Compare
glevco
force-pushed
the
refactor/strict-mypy-5
branch
from
f9b553d to
e738c92
Compare
jansegre
previously approved these changes
Mar 19, 2024
glevco
force-pushed
the
refactor/strict-mypy-4
branch
2 times, most recently
from
1f362af to
20d492d
Compare
glevco
force-pushed
the
refactor/strict-mypy-5
branch
from
e738c92 to
e064a09
Compare
glevco
force-pushed
the
refactor/strict-mypy-4
branch
2 times, most recently
from
20a973d to
b42aa67
Compare
glevco
dismissed stale reviews from jansegre and msbrogli
The base branch was changed.
glevco
force-pushed
the
refactor/strict-mypy-5
branch
from
6ff78af to
650585f
Compare
jansegre
approved these changes
Mar 22, 2024
msbrogli
approved these changes
Mar 22, 2024
glevco
force-pushed
the
refactor/strict-mypy-5
branch
from
650585f to
9159491
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #973
Motivation
This PR continues to improve the strictness of mypy in test modules. For more info see the first PR in this series, #969.
Acceptance Criteria
tests.unittestandtests.utilsmodules and update them to conform.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged