refactor(mypy): add stricter rules to p2p tests [part IV/VI] #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
force-pushed
the
refactor/strict-mypy-3
branch
from
ce34601 to
21bdd94
Compare
glevco
force-pushed
the
refactor/strict-mypy-4
branch
from
bb8ad15 to
5318232
Compare
glevco
force-pushed
the
refactor/strict-mypy-3
branch
from
21bdd94 to
6e1595f
Compare
glevco
force-pushed
the
refactor/strict-mypy-4
branch
from
5318232 to
5235577
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #973 +/- ##
==========================================
+ Coverage 85.06% 85.10% +0.04%
==========================================
Files 294 294
Lines 22800 22801 +1
Branches 3435 3435
==========================================
+ Hits 19394 19405 +11
+ Misses 2720 2713 -7
+ Partials 686 683 -3 ☔ View full report in Codecov by Sentry. |
1 task
glevco
changed the title
glevco
force-pushed
the
refactor/strict-mypy-4
branch
from
5235577 to
ef291c0
Compare
1 task
msbrogli
previously approved these changes
Mar 19, 2024
glevco
force-pushed
the
refactor/strict-mypy-3
branch
from
6e1595f to
2bea84c
Compare
glevco
force-pushed
the
refactor/strict-mypy-4
branch
from
ef291c0 to
1a1d5c8
Compare
jansegre
reviewed
Mar 19, 2024
glevco
force-pushed
the
refactor/strict-mypy-3
branch
from
2bea84c to
639d981
Compare
glevco
force-pushed
the
refactor/strict-mypy-4
branch
from
1a1d5c8 to
59fb234
Compare
glevco
force-pushed
the
refactor/strict-mypy-3
branch
from
639d981 to
5b95253
Compare
glevco
force-pushed
the
refactor/strict-mypy-4
branch
from
1f362af to
20d492d
Compare
jansegre
previously approved these changes
Mar 20, 2024
glevco
force-pushed
the
refactor/strict-mypy-4
branch
from
20d492d to
56ac0ba
Compare
msbrogli
approved these changes
Mar 21, 2024
jansegre
approved these changes
Mar 21, 2024
glevco
force-pushed
the
refactor/strict-mypy-4
branch
from
20a973d to
b42aa67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #972
Motivation
This PR continues to improve the strictness of mypy in test modules. For more info see the first PR in this series, #969.
Acceptance Criteria
tests.p2pmodule and update it to conform.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged