refactor(mypy): unify hathor and test modules strictness [part VI/VI] #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #975 +/- ##
==========================================
+ Coverage 85.06% 85.08% +0.02%
==========================================
Files 295 295
Lines 22866 22866
Branches 3443 3443
==========================================
+ Hits 19450 19455 +5
+ Misses 2725 2724 -1
+ Partials 691 687 -4 ☔ View full report in Codecov by Sentry. |
glevco
force-pushed
the
refactor/strict-mypy-5
branch
from
587695c to
f9b553d
Compare
glevco
force-pushed
the
refactor/strict-mypy-6
branch
from
946b5cc to
773358b
Compare
msbrogli
previously approved these changes
Mar 19, 2024
glevco
force-pushed
the
refactor/strict-mypy-5
branch
from
f9b553d to
e738c92
Compare
glevco
force-pushed
the
refactor/strict-mypy-6
branch
from
773358b to
cad1714
Compare
jansegre
previously approved these changes
Mar 19, 2024
glevco
force-pushed
the
refactor/strict-mypy-5
branch
from
e738c92 to
e064a09
Compare
glevco
force-pushed
the
refactor/strict-mypy-6
branch
from
cad1714 to
2a0c3d0
Compare
glevco
force-pushed
the
refactor/strict-mypy-5
branch
from
6ff78af to
650585f
Compare
glevco
force-pushed
the
refactor/strict-mypy-6
branch
from
2a0c3d0 to
0cbd96f
Compare
glevco
force-pushed
the
refactor/strict-mypy-5
branch
from
650585f to
9159491
Compare
glevco
dismissed stale reviews from jansegre and msbrogli
The base branch was changed.
glevco
force-pushed
the
refactor/strict-mypy-6
branch
from
0cbd96f to
5e00ff5
Compare
jansegre
approved these changes
Mar 22, 2024
glevco
force-pushed
the
refactor/strict-mypy-6
branch
from
5e00ff5 to
b6f1223
Compare
msbrogli
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #974
Motivation
This PR continues to improve the strictness of mypy in test modules. For more info see the first PR in this series, #969.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged