-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: create VertexHandler [part 1/2] #987
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
glevco
force-pushed
the
refactor/multiv/vertex-handler-1
branch
from
April 2, 2024 17:00
60cf712
to
7637c82
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #987 +/- ##
==========================================
+ Coverage 84.92% 85.00% +0.08%
==========================================
Files 296 298 +2
Lines 22875 22925 +50
Branches 3460 3463 +3
==========================================
+ Hits 19426 19488 +62
+ Misses 2764 2756 -8
+ Partials 685 681 -4 ☔ View full report in Codecov by Sentry. |
glevco
force-pushed
the
refactor/multiv/vertex-handler-1
branch
2 times, most recently
from
April 3, 2024 15:36
bc6608a
to
6d7db1f
Compare
glevco
commented
Apr 3, 2024
glevco
changed the title
refactor: create VertexHandler
refactor: create VertexHandler [part 1/2]
Apr 3, 2024
glevco
force-pushed
the
refactor/multiv/vertex-handler-1
branch
from
April 14, 2024 20:33
6d7db1f
to
1a598bc
Compare
msbrogli
previously approved these changes
Apr 23, 2024
glevco
force-pushed
the
refactor/multiv/vertex-handler-1
branch
from
April 23, 2024 22:08
1a598bc
to
6176f19
Compare
jansegre
approved these changes
Apr 24, 2024
msbrogli
approved these changes
Apr 24, 2024
glevco
force-pushed
the
refactor/multiv/vertex-handler-1
branch
from
April 25, 2024 19:54
6176f19
to
13e7a24
Compare
This was referenced May 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Move all
HathorManager.on_new_tx()
related code to its own new class,VertexHandler
, improving organization and modularization, and as a prerequisite for the upcoming changes related to multiprocess verification.Acceptance Criteria
HathorManager.on_new_tx()
implementation to newVertexHandler
, along with other methods used only by it.conn
andskip_block_weight_verification
arguments were removed, since they were not used.HathorManager.on_new_tx()
with a call toVertexHandler.on_new_tx()
, compatibility with current code.Builder
andCliBuilder
accordingly.TestBuilder._get_reactor()
(it was not persisting the newly created reactor instance).Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged