-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(vertex-handler): modularize methods [part 2/2] #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
force-pushed
the
refactor/multiv/vertex-handler-1
branch
from
April 2, 2024 17:00
60cf712
to
7637c82
Compare
glevco
force-pushed
the
refactor/multiv/on-new-vertex-2
branch
from
April 2, 2024 17:00
e7c18db
to
de99a60
Compare
glevco
force-pushed
the
refactor/multiv/vertex-handler-1
branch
from
April 2, 2024 18:09
7637c82
to
bc6608a
Compare
glevco
force-pushed
the
refactor/multiv/on-new-vertex-2
branch
from
April 2, 2024 18:09
de99a60
to
6a690a9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #988 +/- ##
==========================================
- Coverage 84.94% 84.90% -0.05%
==========================================
Files 298 298
Lines 22928 22932 +4
Branches 3464 3465 +1
==========================================
- Hits 19476 19470 -6
- Misses 2767 2772 +5
- Partials 685 690 +5 ☔ View full report in Codecov by Sentry. |
1 task
glevco
force-pushed
the
refactor/multiv/vertex-handler-1
branch
from
April 3, 2024 15:36
bc6608a
to
6d7db1f
Compare
glevco
force-pushed
the
refactor/multiv/on-new-vertex-2
branch
from
April 3, 2024 15:38
6a690a9
to
e6e5b87
Compare
glevco
changed the title
refactor(vertex-handler): modularize methods
refactor(vertex-handler): modularize methods [part 2/2]
Apr 3, 2024
glevco
force-pushed
the
refactor/multiv/vertex-handler-1
branch
from
April 14, 2024 20:33
6d7db1f
to
1a598bc
Compare
glevco
force-pushed
the
refactor/multiv/on-new-vertex-2
branch
from
April 14, 2024 20:34
e6e5b87
to
d3f444f
Compare
msbrogli
previously approved these changes
Apr 23, 2024
glevco
force-pushed
the
refactor/multiv/vertex-handler-1
branch
from
April 23, 2024 22:08
1a598bc
to
6176f19
Compare
glevco
force-pushed
the
refactor/multiv/on-new-vertex-2
branch
from
April 23, 2024 22:11
d3f444f
to
0a3f803
Compare
jansegre
previously approved these changes
Apr 24, 2024
glevco
force-pushed
the
refactor/multiv/vertex-handler-1
branch
from
April 25, 2024 19:54
6176f19
to
13e7a24
Compare
glevco
force-pushed
the
refactor/multiv/on-new-vertex-2
branch
from
April 25, 2024 19:55
0a3f803
to
d4cf46b
Compare
glevco
dismissed stale reviews from jansegre and msbrogli
April 25, 2024 22:44
The base branch was changed.
glevco
force-pushed
the
refactor/multiv/on-new-vertex-2
branch
from
April 25, 2024 22:46
d4cf46b
to
2cb1780
Compare
jansegre
approved these changes
Apr 26, 2024
msbrogli
approved these changes
Apr 26, 2024
glevco
force-pushed
the
refactor/multiv/on-new-vertex-2
branch
from
April 26, 2024 17:21
2cb1780
to
e09d336
Compare
This was referenced May 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #987
Motivation
Modularize
on_new_tx()
as a prerequisite for the upcoming changes related to multiprocess verification, in order to create a new aysncon_new_tx()
(we should be able to duplicate the method without copying all code).Acceptance Criteria
VertexHandler.on_new_tx()
toon_new_vertex()
.on_new_vertex()
into modularized methods,_validate_vertex()
,_save_and_run_consensus()
, and_post_consensus()
(renamed fromtx_fully_validated()
).Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged