Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] sys tests for nodejs #10436

Open
3 of 6 tasks
tobil4sk opened this issue Oct 17, 2021 · 1 comment
Open
3 of 6 tasks

[CI] sys tests for nodejs #10436

tobil4sk opened this issue Oct 17, 2021 · 1 comment
Milestone

Comments

@tobil4sk
Copy link
Member

tobil4sk commented Oct 17, 2021

sys api tests are currently not run for nodejs (as this is not a sys target by default).
They now have been added.

These can be added for nodejs, however, there exist the following limitations:

  • sys.io.File.update() is not present in the hxnodejs api
  • eof checks work differently in hxnodejs compared to other targets
  • On unix, hxnodejs's FileSystem.absolutePath("c:\filepath") returns "/path/to/cwd/c:\filepath", whereas on other Haxe targets it just returns "c:\filepath"
  • sys.io.Process does not exist in hxnodejs
  • sys.net.Socket.bind() is not implemented in hxnodejs
  • The test for sys.io.File.append() fails on Mac

I created hxnodejs PRs to fix the first three:

For the rest, the tests can temporarily be removed for nodejs using conditional compilation, and they can be added back later when/if the APIs are updated.

@RealyUniqueName RealyUniqueName added this to the Backlog milestone Oct 20, 2021
@tobil4sk
Copy link
Member Author

Most of the tests are now enabled since #10437, just apart from those broken by the last three things mentioned in the checklist in the original post. These have been disabled temporarily via conditional compilation.

@Simn Simn modified the milestones: Backlog, Later Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants