-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Enable sys tests for NodeJS #10437
Conversation
54ddc9f
to
a0e55a3
Compare
Looks like this needs a few more fixes. |
@Simn I submitted another PR to fix the issue with |
Thanks, just to clarify these are the other two PRs that will need to be merged as well apart from that one: |
|
That particular file already has a lot of conditional compilation for stuff not working on various targets. Feel free to do that for this case as well for the time being. That way we can merge this PR now and track the issue in an issue. |
Disabled it on Mac, and mentioned the issue in the checklist #10436. Might be good for those to be moved into separate issues in |
CI finally behaved. Thank you for this contribution! |
Great, thanks for your time! |
Addresses #10436 partially.
Previously, the
sys
api tests for nodejs were not running. This PR enables most of them, apart from those that cannot be enabled currently becausesys.io.Process
andsys.net.Socket.bind()
are not implemented inhxnodejs
.These hxnodejs PR need to be merged so that the tests run successfully:
update
method to File api hxnodejs#180sys.FileSystem.absolutePath
hxnodejs#182