[sys] Fix Sys.putEnv() with null as variable value on all targets

[tobil4sk]

Fixes #10395

Running Sys.putEnv() now works consistently across targets when null is passed in as the value parameter, in which case it deletes the environment variable.

Testing for this case has been added as well.

This PR depends on the following PRs in other repositories:

• Add null check to _hx_std_put_env() hxcpp#965
• Handle null as value for Sys.putEnv() hxnodejs#179
• Add null case to put_env function in sys neko#233

Depends on:

• [CI] Enable sys tests for NodeJS #10437

[RealyUniqueName]

CI changes don't fit this PR.

[tobil4sk]

Dropped the other commits to leave only the ones needed for this PR.

Adding the sys tests for nodejs is necessary here so that we can test if the issue has been fixed there (but i can separate it into a different PR if needed).

[tobil4sk]

Created a separate PR (#10437) for enabling the sys tests on nodejs. I have a rebased version of this branch ready to push once that one is merged.

[RealyUniqueName]

Resolve conflicts please.

[tobil4sk]

Resolved

[RealyUniqueName]

Some tests fail.

[tobil4sk]

These tests are failing because hxcpp, neko and nodejs require target specific changes in their respective repositories. I made PRs for these changes which I listed in the first post. Here they are again to confirm:

• Handle null as value for Sys.putEnv() hxnodejs#179
• Add null check to _hx_std_put_env() hxcpp#965
• Add null case to put_env function in sys neko#233

Once these are merged and the tests are using the fixed versions they should all pass.

[tobil4sk]

The neko tests are still failing because the updated neko version isn't being deployed. For the Windows cpp tests I'll have to debug those.

[tobil4sk]

Windows CPP tests should be fixed once HaxeFoundation/hxcpp/pull/973 is merged.

[tobil4sk]

I opened an issue about neko CI failing to upload the new binaries: HaxeFoundation/neko/issues/235

Once that is fixed and the new neko builds can be downloaded properly, the remaining failing tests (which are just neko) should run successfullly.

[tobil4sk]

I made a PR for neko that might fix the deployment issue: HaxeFoundation/neko#236.

Then, to ensure this bug is fixed (for neko) with the next haxe release what has to be done is:

• make a neko release
  To hopefully speed this up I did Add changelog for 2.3.1 neko#237 and [CI] Generate chocolatey scripts automatically neko#238.
  After those I think all that needs to be done is for a tag to be created, for the chocolatey package to be uploaded, and also an update to the website which I'd be happy to create a PR for as well https://github.com/HaxeFoundation/nekovm.org
• update the versions of neko packaged with official Haxe releases
  I have a local commit for this which I can push once the updates are up, but maybe that can be a separate PR.

[Simn]

I appreciate your resilience in dealing with this stuff...

[tobil4sk]

Thanks! Looks like this is going to take quite a bit more resilience because there's no way of knowing currently if that fix worked since a new failure appeared out of nowhere in the Mac build...

[tobil4sk]

Alright, I think neko's mac CI issue is resolved, I listed the PRs needed to fix it here: HaxeFoundation/neko#240

Then we'll be able to see if the deployment is working...

[Simn]

Something is now broken on Linux:

Uncaught exception - load.c(237) : Failed to load library : /home/runner/work/_temp/neko-2.3.1-linux64/std.ndll (/lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by /home/runner/work/_temp/neko-2.3.1-linux64/std.ndll))
Makefile:105: recipe for target 'haxelib' failed

[tobil4sk]

Yes... This just doesn't end 👀 I think for now what's best is to temporarily download the old version of neko for CI, because this isn't going to be an issue only for this PR.

[tobil4sk]

Seems like an issue caused by building neko in ubuntu 20.04 and haxe in 18.04 (probably due to c compiler toolkit differences). I created a PR to update it here #10457. Another option could be to use 18.04 to bulid neko and see if that fixes it? That might potentially be better for backwards compatibility, but haven't tested it.

[tobil4sk]

I created a PR as well to build neko in an older version of ubuntu as well: HaxeFoundation/neko#241. Hopefully either solution should work.

[Simn]

You are the hero we need!

[tobil4sk]

Finally all green!

[Simn]

Wohoo! Let's quickly merge it before it changes its mind.

[tobil4sk]

Thanks! I'll move the stuff about updating the version of neko haxe is packaged with to a new issue.