Fix behaviour of FileInput.eof() #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used the c# implementation for reference, now it passes the sys tests in the compiler repository
This was referenced Oct 18, 2021
|
The leading underscore naming here seems a bit unusual... |
|
My thinking behind that is that it's not an actual part of the cross platform API for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the behaviour of sys.io.FileInput.eof(). Previously, it was not consistent with other targets which meant that nodejs couldn't be tested with the other sys targets in the Haxe repository. I looked at how Haxe wraps this behaviour for C# and implemented it like that.