[ide] collect_implementations in statistics.ml needs optimization

[nadako]

18:49
nadako well.. if I'm understanding correctly, that loops through like 90% of the codebase for every field, because there are things like IEventDispatcher (edited)

[nadako]

This one is pretty high-priority for us, because "find references" basically hangs in processing and I think it affects a lot of code.

[nadako]

so far we've found out that cl_descendants that this function is working on is a mess, containing duplicates and (apparently) cycles which causes an infinite loop.

[nadako]

ok, I couldn't spot actual cycles, so my new version is that it's just hundreds of duplicates of the very basic framework classes (e.g. Sprite), which has hundreds of duplicates of application base classes, which has hundreds of duplicates of concrete classes and so on, which leaves us with a huge amount of data to process so maybe it would finish if I gave it a day or so ^^

#9506 sidesteps this issue, but we still need to figure out why there are duplicates in cl_descendants and fix it (also because it might affect DCE and other places in the code that uses it).

[nadako]

More observations:

Adding assert (not (List.memq descendant c.cl_descendants)) to add_descendant doesn't break compilation (cache server or not), so I assume everything is fine on that front, however "Find References" now gives this error:

[Error - 23:57:23] Request textDocument/references failed.
  Message: Field _createBottomButtons should be declared with 'override' since it is inherited from superclass de.innogames.strategycity.shared.ui.window.BaseTabWindow

Which is something I've actually seen before when checking some other issues, so I guess we also have a pokemon catch somewhere that swallows the assertion failure?

(_createBottomButtons is the method that we're asking and it has override)

[nadako]

I think I know where duplicates are coming from. We're calling find_references (and thus collect_statistics which sets up cl_descendants) multiple times here:

haxe/src/context/display/findReferences.ml

Line 101 in 9a75d9d

acc @ (find_references tctx com with_definition name pos kind)

[nadako]

However, if I move "set up descendants" out and call it before the find_references loop, it still gets duplicates, and I don't know why.