Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Make mac universal builds more universal #11663

Merged
merged 7 commits into from
Jul 2, 2024

Conversation

tobil4sk
Copy link
Member

@tobil4sk tobil4sk commented May 9, 2024

Right now the haxelib binary in the "universal" mac builds is only x64. To fix this we need to build haxelib with an arm64 build of neko.

First we need arm64 builds of neko, see:
HaxeFoundation/neko#288

@skial skial mentioned this pull request May 9, 2024
1 task
tobil4sk referenced this pull request in openfl/lime May 10, 2024
This seems to be required with Xcode 15, but was not required previously
@tobil4sk tobil4sk force-pushed the fix/mac-arm64-haxelib branch from 52dd092 to b7a6443 Compare June 6, 2024 14:22
@tobil4sk
Copy link
Member Author

tobil4sk commented Jun 6, 2024

The arm64 builds of neko are now available at https://build.haxe.org/builds/neko/mac-arm64/. However, the mac installer package script needs to be updated to use a universal binary for neko as well.

@kLabz
Copy link
Contributor

kLabz commented Jun 28, 2024

However, the mac installer package script needs to be updated to use a universal binary for neko as well.

Hi @tobil4sk!
We'd like to move this whole universal mac thing forward to release it (on 4.3.x too), but I'm not sure what this means needs to be done exactly 🤔

@tobil4sk
Copy link
Member Author

The next step is to create universal neko binaries. The easiest way to do this is to update the neko repo so that it also creates them.

The makefile for creating the package installer pulls the binaries from a github release, so we'll need a new neko release on github to host the binaries. We could use a prerelease to test everything is working. There's a few neko PRs that would be good to get in before a final release though.

@kLabz
Copy link
Contributor

kLabz commented Jun 28, 2024

Thanks! Though I'm not sure yet how to proceed there.

We might want to keep the neko changes to a minimum for now (4.3.5 release) though; what do you think @Simn ?

@Simn
Copy link
Member

Simn commented Jun 28, 2024

I agree.

tobil4sk added 4 commits June 28, 2024 20:13
It can still be configured to specific architectures if needed, using
`PACKAGE_INSTALLER_MAC_ARCH`.
This version fixes a permission issue with universal mac binaries
@Simn Simn merged commit d3cb40e into HaxeFoundation:development Jul 2, 2024
50 checks passed
@tobil4sk tobil4sk deleted the fix/mac-arm64-haxelib branch July 2, 2024 14:36
kLabz pushed a commit that referenced this pull request Jul 18, 2024
* [ci] Install arm64 neko for arm64 mac builds

* [ci] Create universal binary for haxelib

* [ci] Build native haxelib binary on arm64 mac

* [make] Use universal neko binaries for mac package

It can still be configured to specific architectures if needed, using
`PACKAGE_INSTALLER_MAC_ARCH`.

* [make] Default to host arch for mac installer

* [make] Use neko version 2.4.0-rc

* [make] Use neko version 2.4.0-rc.1

This version fixes a permission issue with universal mac binaries
kLabz pushed a commit that referenced this pull request Jul 18, 2024
* [ci] Install arm64 neko for arm64 mac builds

* [ci] Create universal binary for haxelib

* [ci] Build native haxelib binary on arm64 mac

* [make] Use universal neko binaries for mac package

It can still be configured to specific architectures if needed, using
`PACKAGE_INSTALLER_MAC_ARCH`.

* [make] Default to host arch for mac installer

* [make] Use neko version 2.4.0-rc

* [make] Use neko version 2.4.0-rc.1

This version fixes a permission issue with universal mac binaries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants