Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Path.UniqueKey.create #9535

Conversation

RealyUniqueName
Copy link
Member

@RealyUniqueName RealyUniqueName commented Jun 4, 2020

Closes #9509

@Simn
Copy link
Member

Simn commented Jun 4, 2020

I thought that we could just have an (opaque?) type which replaces m_file : string, and then a small API for it to get the original file and the cached unique file.

This works as well, but I don't like having closure objects on our data very much.

@RealyUniqueName
Copy link
Member Author

@Simn I've added UniqueKey.lazy_t and changed m_file to this type.

@Simn
Copy link
Member

Simn commented Jun 5, 2020

Yeah I think this is better!

@skial skial mentioned this pull request Jun 5, 2020
1 task
@RealyUniqueName RealyUniqueName added this to the Hotfix milestone Jun 5, 2020
@RealyUniqueName RealyUniqueName merged commit 7a3f246 into HaxeFoundation:development Jun 5, 2020
@RealyUniqueName RealyUniqueName modified the milestones: Hotfix, Release 4.2 Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

server/invalidate calls Path.UniqueKey.create for every cached module
2 participants