-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing methods which are causing issues in haxe.zip.Reader #160
add missing methods which are causing issues in haxe.zip.Reader #160
Conversation
Does this really help with anything? Looks like it will just lead to a runtime error as soon as you call the constructor. |
Yeah it's stops a compile error. In the std lib, haxe.zip.Reader calls |
But it doesn't look like this actually solves anything, it just moves the error from compile time to runtime? |
Hmm that's not entirely true, It moves the error from always happening at compile time, to only happening when you call a particular method on Reader. For example I'm not using Reader, but because of this in compatibility my whole app won't compile. And if you are using Reader then your no worse off, as your app already won't be compiling. |
Hm, I see... Do you have a code example? |
It's GMT+10 so not at my computer. But basically hxnodejs overrides a std class and removes a bunch of methods, this is going to cause issues, shouldn't need a code example to see this. Could you just merge please |
Calm down. :) It's not about understanding, I was thinking it would make for a good test case for unit tests / CI. But it looks like I misremembered and we don't actually have unit tests for hxnodejs, just these examples. |
It's probably fine to merge this, tho for |
Thanks |
No description provided.