Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added basic, incomplete compress/uncompress implementation #52

Closed
wants to merge 2 commits into from

Conversation

clemos
Copy link
Contributor

@clemos clemos commented Nov 16, 2015

to be completed...

@nadako
Copy link
Member

nadako commented Nov 16, 2015

I believe there's a problem described in #42 with this.

@ncannasse
Copy link
Member

please remove the traces :)
@nadako not sure which problem, if the API is correctly respected. Of course, it will be nice to have progressive (un)compress support as well

@clemos clemos force-pushed the compress-uncompress-support branch from b805cc2 to 8067dc5 Compare November 16, 2015 15:46
@nadako
Copy link
Member

nadako commented Nov 16, 2015

@ncannasse the problem of these implementations overshadowing ones in std, so macros don't work.

@clemos
Copy link
Contributor Author

clemos commented Nov 16, 2015

I just removed the traces.
Honestly, I would definitely implement the rest of the API in both PHP and JS, if only it had some documentation and / or unit tests...

@kevinresol
Copy link
Contributor

copyright year should be 2015 😛

@ncannasse
Copy link
Member

@nadako ah right, macros. But that can be addressed by merging haxe/std/neko/_std/haxe/zip implementation into it (with #if neko)

@nadako
Copy link
Member

nadako commented Nov 18, 2015

yeah but that's not good for obvious reasons of code duplication and maintainance, so I'd really like to see some "proper" solution for that

@ncannasse
Copy link
Member

@nadako see HaxeFoundation/haxe#4249

@nadako
Copy link
Member

nadako commented Mar 17, 2016

As @Simn pointed out, we could try placing these files in js/_std/haxe/zip and see if it works.

@Gama11
Copy link
Member

Gama11 commented Apr 16, 2020

This seems obsolete after #160 (plus there's merge conflicts).

@Gama11 Gama11 closed this Apr 16, 2020
@Gama11 Gama11 deleted the compress-uncompress-support branch April 16, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants