Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mesf npc/woe-fe #2262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

mesf npc/woe-fe #2262

wants to merge 1 commit into from

Conversation

Habilya
Copy link
Contributor

@Habilya Habilya commented Oct 6, 2018

Pull Request Prelude

Changes Proposed

npc/woe-fe concatenation in mes replaced with mesf.

Affected Branches:
master
//: # (Master? Slave?)

Issues addressed:
#2233
//: # (Issue Tracker Number if any.)

Known Issues and TODO List

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@Emistry Emistry added the component:scripts Affecting the scripts and NPCs label Oct 19, 2018
@dastgirp dastgirp added this to the Release v2019.02.10 milestone Dec 19, 2018
Copy link
Contributor

@AnnieRuru AnnieRuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. some lines are not translated
    https://github.com/HerculesWS/Hercules/blob/stable/npc/woe-fe/agit_main.txt#L107
    https://github.com/HerculesWS/Hercules/blob/stable/npc/woe-fe/agit_main.txt#L125
    https://github.com/HerculesWS/Hercules/blob/stable/npc/woe-fe/agit_main.txt#L167
    and this is just the few 1st 100 lines I spot

  2. actually, instead of having

//== Guild Flags (Outside Castle) ==========================
-	script	Neuschwanstein#1::OutsideFlagsA1	GUILD_FLAG,{

	.@GID = getcastledata("aldeg_cas01",1);

why not

if (strnpcinfo(NPC_NAME_VISIBLE) == "Neuschwanstein") {
	.@map$ = "aldeg_cas01";
	.@x = 218;
	.@y = 170;
	.@GID = getcastledata(.@map$, 1);
}
else if (strnpcinfo(NPC_NAME_VISIBLE) == "Hohenschwangau") {
...

and duplicate all these npc from agit_main.txt ?

Euphy has already done something like this in woe:se,
I don't see a reason why not do like this in woe:fe

@AnnieRuru AnnieRuru removed this from the Release v2019.03.10 milestone Feb 28, 2019
@AnnieRuru AnnieRuru self-assigned this Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:scripts Affecting the scripts and NPCs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants