-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making Scripts compatible with Hercules Ultimate Localization Design (HULD) #2233
Labels
complexity: 1-straightforward
Issue can be resolved easily
hacktoberfest-accepted
Easy-to-tackle issues
Comments
dastgirp
added
hacktoberfest-accepted
Easy-to-tackle issues
complexity: 1-straightforward
Issue can be resolved easily
labels
Oct 1, 2018
I am currently working on it. Would it be alright if I ask my doubts here or on the discord channel ? |
@linton-dawson you can ask your doubts anywhere you feel comfortable |
3 tasks
This was referenced Oct 6, 2018
Merged
Open
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
complexity: 1-straightforward
Issue can be resolved easily
hacktoberfest-accepted
Easy-to-tackle issues
Issue Prelude
Description
Currently, we do not have all the scripts which are compatible with HULD (if you want to know what's HULD, you can visit here: http://herc.ws/board/topic/8687-hercules-ultimate-localization-design/ , but I would be explaining the issue and solution here so it's easy to do)
Currently our translation only recognizes following commands:
So, let's take npc/cities/aldebaran.txt (https://github.com/HerculesWS/Hercules/raw/master/npc/cities/aldebaran.txt) for example,
The changes we need to make:
will be converted to
will be converted to
Note: mesf is mes + sprintf, if you want more info, you can visit here : https://raw.githubusercontent.com/HerculesWS/Hercules/master/doc/script_commands.txt and search mesf
To
Example 2:
To
Note: You may find many more functions/commands for the same, some of them are listed below, but not limited to:
In some script, the select would be in the following format, which needs to be changed
To
To
Note: Remember, The variables can have either empty suffix or $ as suffix, if it's $ in suffix, it's a string, and %s should be there in sprintf/mesf, for no suffix, %d should be used
Files to be changed:
Files ending with extension .txt in npc/ folder (some files in that folder are already changed to support this, while many are remaining to be changed)
This issue can be done in parts (multiple PR's), as we know that there are lots of scripts to be changed, and a single person cannot do them all
Additional Info
If there's any doubt or need information, you can ask any of the contributor or join the discord channel https://discord.gg/ZUzbRSp
Reference
You can refer to already converted scripts such as:
https://github.com/HerculesWS/Hercules/blob/stable/npc/re/instances/MalangdoCulvert.txt
https://github.com/HerculesWS/Hercules/blob/stable/npc/re/instances/BakonawaLake.txt
https://github.com/HerculesWS/Hercules/blob/stable/npc/re/instances/EclageInterior.txt
The text was updated successfully, but these errors were encountered: