Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/npc mes ""; to mes(""); #2257

Closed
wants to merge 30 commits into from
Closed

/npc mes ""; to mes(""); #2257

wants to merge 30 commits into from

Conversation

Habilya
Copy link
Contributor

@Habilya Habilya commented Oct 4, 2018

Pull Request Prelude

Changes Proposed

Affected Branches:
master
//: # (Master? Slave?)

Issues addressed:
#2233
//: # (Issue Tracker Number if any.)

Known Issues and TODO List

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@Helianthella Helianthella added type:enhancement Issue describes an enhancement or feature that should be implemented status:code-review Awaiting code review component:core:scriptengine Affecting the script engine or the script commands labels Oct 4, 2018
@Helianthella Helianthella added this to the Release v2018.11.18 milestone Oct 4, 2018
@dastgirp
Copy link
Member

dastgirp commented Oct 5, 2018

Please fix the errors: https://travis-ci.org/HerculesWS/Hercules/jobs/437303667

4144
4144 requested changes Oct 5, 2018
View reviewed changes
Copy link
Contributor

@4144 4144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see ci output. you had some syntax errors

@4144
Copy link
Contributor

4144 commented Oct 5, 2018

please squash fixes commits into other commits. because fix commits for non merged commits is useless

@Emistry
Copy link
Member

Emistry commented Oct 5, 2018

fyi, there exists so many of extra ; in the npc dialog, perhaps review each lines you have edited?

@dastgirp
Copy link
Member

dastgirp commented Oct 6, 2018

As per request, closing it

@dastgirp dastgirp closed this Oct 6, 2018
@dastgirp dastgirp added invalid Issue isn't a Hercules bug (user mistake, intentional behavior, unsupported setup, etc) and removed status:code-review Awaiting code review labels Oct 6, 2018
@MishimaHaruna MishimaHaruna removed this from the Release v2018.11.18 milestone Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4144 4144 4144 requested changes

Assignees
No one assigned
Labels
component:core:scriptengine Affecting the script engine or the script commands invalid Issue isn't a Hercules bug (user mistake, intentional behavior, unsupported setup, etc) type:enhancement Issue describes an enhancement or feature that should be implemented
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Habilya @HerculesWSAPI @dastgirp @4144 @Emistry @Helianthella @MishimaHaruna