-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mesf npc/warps #2263
base: master
Are you sure you want to change the base?
mesf npc/warps #2263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's better to use \r, since some language might represent sentence in other way
mes "certain dragon body parts"; | ||
mes "would fit perfectly into"; | ||
mes "the column grooves.^000000"; | ||
mes("^3355FFThere are 3 oddly"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as this is single sentence split into multiple lines, I recommend that you use \r
Example:
mes("^3355FFThere are 3 oddly\r"
"shaped grooves on\r"
"the surface of this\r"
"column. It seems that\r"
"certain dragon body parts\r"
"would fit perfectly into\r"
"the column grooves.^000000";
mes "the grooves, and then you"; | ||
mes "hear a powerful rumbling"; | ||
mes "from within the column.^000000"; | ||
mes("^3355FFYou carefully place a"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, use \r and concat
mes "of the column's grooves,"; | ||
mes "trigerring another small"; | ||
mes "tremor from the column.^000000"; | ||
mes("^3355FFYou slowly insert a"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, use \r and concat
mes "final groove. Lights shine"; | ||
mes "forth from cracks in the"; | ||
mes "column's surface...^000000"; | ||
mes("^3355FFYou cautiously insert"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, use \r and concat
mes "to chew. Nothing happens"; | ||
mes "and the taste of these items"; | ||
mes "is surprisingly putrid.^000000"; | ||
mes("^3355FFYou gingerly place a"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, use \r and concat
mes "You accidentally"; | ||
mes "broke the item.^000000"; | ||
mes("^3355FF*Ppppsssh!*"); | ||
mes("You accidentally"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, use \r and concat
mes "make it difficult to stand"; | ||
mes "steadily, but suddently you"; | ||
mes "are warped somewhere else...^000000"; | ||
mes("^3355FFThe light emanating from"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, use \r and concat
next; | ||
mes "Please select a"; | ||
mes "state for the arena."; | ||
mes("Please select a"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, use \r and concat
next; | ||
switch(select("Open.:Closed.")) { | ||
case 1: | ||
mes "Currently"; | ||
mes "opening arena."; | ||
mes("Currently"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, use \r and concat
specialeffect EF_ENHANCE; | ||
enablenpc "welcome_arena"; | ||
close; | ||
case 2: | ||
mes "Currently"; | ||
mes "closing arena."; | ||
mes("Currently"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, use \r and concat
Pull Request Prelude
Changes Proposed
npc/warps concatenation in mes replaced with mesf.
//: # (Describe at length, the changes that this pull request makes.)
Affected Branches:
master
Issues addressed:
#2233
//: # (Issue Tracker Number if any.)
Known Issues and TODO List