Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mesf npc/other #2306

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

mesf npc/other #2306

wants to merge 1 commit into from

Conversation

Habilya
Copy link
Contributor

@Habilya Habilya commented Oct 23, 2018

Pull Request Prelude

Changes Proposed

mes to mesf npc/other

Issues addressed:
#2233

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@Emistry Emistry added the component:scripts Affecting the scripts and NPCs label Dec 14, 2018
mes "is "+@record_min60+"minutes "+@record_sec60+"seconds.";
mes "Congratulations!";
mes("[Staff]");
mesf("is %dminutes %dseconds.", @record_min60, @record_sec60);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add space between numbers of minutes and seconds

Suggested change
mesf("is %dminutes %dseconds.", @record_min60, @record_sec60);
mesf("is %d minutes %d seconds.", @record_min60, @record_sec60);

mes "[Staff]";
mes "^3131FF"+$arena_60topn$+"^000000's running time was ^3131FF"+$top_60min+"^000000minutes ^3131FF"+$top_60sec+"^000000seconds.";
mes("[Staff]");
mesf("^3131FF%s^000000's running time was ^3131FF%d^000000minutes ^3131FF%d^000000seconds.", $arena_60topn$, $top_60min, $top_60sec);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mesf("^3131FF%s^000000's running time was ^3131FF%d^000000minutes ^3131FF%d^000000seconds.", $arena_60topn$, $top_60min, $top_60sec);
mesf("^3131FF%s^000000's running time was ^3131FF%d^000000 minutes ^3131FF%d^000000 seconds.", $arena_60topn$, $top_60min, $top_60sec);

mes "is "+@record_min70+"minutes "+@record_sec70+"seconds.";
mes "Congratulations!";
mes("[Staff]");
mesf("is %dminutes %dseconds.", @record_min70, @record_sec70);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mesf("is %dminutes %dseconds.", @record_min70, @record_sec70);
mesf("is %d minutes %d seconds.", @record_min70, @record_sec70);

mes "[Staff]";
mes "^3131FF"+$arena_70topn$+"^000000's running time was ^3131FF"+$top_70min+"^000000minutes ^3131FF"+$top_70sec+"^000000seconds.";
mes("[Staff]");
mesf("^3131FF%s^000000's running time was ^3131FF%d^000000minutes ^3131FF%d^000000seconds.", $arena_70topn$, $top_70min, $top_70sec);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mesf("^3131FF%s^000000's running time was ^3131FF%d^000000minutes ^3131FF%d^000000seconds.", $arena_70topn$, $top_70min, $top_70sec);
mesf("^3131FF%s^000000's running time was ^3131FF%d^000000 minutes ^3131FF%d^000000 seconds.", $arena_70topn$, $top_70min, $top_70sec);

mes "is "+@record_min80+"minutes "+@record_sec80+"seconds.";
mes "Congratulations!";
mes("[Staff]");
mesf("is %dminutes %dseconds.", @record_min80, @record_sec80);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mesf("is %dminutes %dseconds.", @record_min80, @record_sec80);
mesf("is %d minutes %d seconds.", @record_min80, @record_sec80);

mes "[Staff]";
mes "^3131FF"+$arena_80topn$+"^000000's running time was ^3131FF"+$top_80min+"^000000minutes ^3131FF"+$top_80sec+"^000000seconds.";
mes("[Staff]");
mesf("^3131FF%s^000000's running time was ^3131FF%d^000000minutes ^3131FF%d^000000seconds.", $arena_80topn$, $top_80min, $top_80sec);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mesf("^3131FF%s^000000's running time was ^3131FF%d^000000minutes ^3131FF%d^000000seconds.", $arena_80topn$, $top_80min, $top_80sec);
mesf("^3131FF%s^000000's running time was ^3131FF%d^000000 minutes ^3131FF%d^000000 seconds.", $arena_80topn$, $top_80min, $top_80sec);

mes "is "+@record_minpt+"minutes "+@record_secpt+"seconds.";
mes "Congratulations!";
mes("[Staff]");
mesf("is %dminutes %dseconds.", @record_minpt, @record_secpt);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mesf("is %dminutes %dseconds.", @record_minpt, @record_secpt);
mesf("is %d minutes %d seconds.", @record_minpt, @record_secpt);

mes "[Staff]";
mes "^3131FF"+$arena_pttopn$+"^000000's running time was ^3131FF"+$top_ptmin+"^000000minutes ^3131FF"+$top_ptsec+"^000000seconds.";
mes("[Staff]");
mesf("^3131FF%s^000000's running time was ^3131FF%d^000000minutes ^3131FF%d^000000seconds.", $arena_pttopn$, $top_ptmin, $top_ptsec);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mesf("^3131FF%s^000000's running time was ^3131FF%d^000000minutes ^3131FF%d^000000seconds.", $arena_pttopn$, $top_ptmin, $top_ptsec);
mesf("^3131FF%s^000000's running time was ^3131FF%d^000000 minutes ^3131FF%d^000000 seconds.", $arena_pttopn$, $top_ptmin, $top_ptsec);

mes "is accessible to players from ^FF0000level 10^000000 to ^FF0000level "+(RENEWAL?"160":"99")+"^000000.";
mes("[Lunic]");
mes("^3131FFParty Arena Stage^000000");
mesf("is accessible to players from ^FF0000level 10^000000 to ^FF0000level %s^000000.", (RENEWAL?"160":"99"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mesf("is accessible to players from ^FF0000level 10^000000 to ^FF0000level %s^000000.", (RENEWAL?"160":"99"));
mesf("is accessible to players from ^FF0000level 10^000000 to ^FF0000level %d^000000.", MAX_LEVEL);

//= ============ ============================================= ============
//= ============ ���������������������������������������������� ============
//= ============ ������������������������������������������������������������������������������������������ ============
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

encoding changed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:scripts Affecting the scripts and NPCs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants