HULD Compatibility for aldebaran.txt #2272
Conversation
|
This change is |
There was a problem hiding this comment.
There's many mistake in the PR.
You can check Travis build of this PR to know more about error
Current Travis build link: https://travis-ci.org/HerculesWS/Hercules/jobs/438437787
Alternatively you can also use https://haru.ws/scriptchecker/ to check if there's any error on script.
npc/cities/aldebaran.txt
Outdated
| cutin "",255; | ||
| close; | ||
| } | ||
| RESRVPTS -= .@points; | ||
| callfunc "F_Lottery"; | ||
| callfunc "F_Lottery"); |
There was a problem hiding this comment.
Only one bracket here.
You can change it to callfunc("F_Lottery"); or leave it alone (as this PR is for Huld)
There was a problem hiding this comment.
Really sorry for this ! Will fix it ASAP.
npc/cities/aldebaran.txt
Outdated
| @@ -1079,8 +1079,8 @@ aldeba_in,79,161,6 script Kafra#04 4_F_KAFRA3,{ | |||
| 800, Sweet_Potato, 85, | |||
| 900, Sweet_Potato, 100, | |||
| 1000, null, 0; | |||
| .@ordinal$ = "1st"; | |||
| .@changepage$ = "Next items"; | |||
| .@ordinal$ = "1st"); | |||
| getitem .@choices[.@chosen*3 + 1], .@choices[.@chosen*3 + 2]; | ||
| close; | ||
| } | ||
| // Lottery chance | ||
| mes "^0000FF"+ .@ordinal$ + " Lottery Opportunity!!^000000"; | ||
| mesf("^0000FF %s Lottery Opportunity!!^000000",.@ordinal$); |
There was a problem hiding this comment.
use F_MesColor function here
look, if using google machine translation the ^000000 becomes ^ 000000 <-- it adds a space,
using F_MesColor function will eliminate this problem
| ++.@numitemchoices; | ||
| } | ||
| .@list$ += .@choices[.@i] + "- " + .@ordinal$ + " Lottery Chance!:" + .@changepage$ +":Cancel"; | ||
| .@list$ +=sprintf(_$("%d- %s Lottery Chance!:%s:Cancel"), .@choices[.@i], .@ordinal$, .@changepage$); |
There was a problem hiding this comment.
.@list$ +=sprintf(_$("%1$d- %2$s Lottery Chance!:%3$s:Cancel"), .@choices[.@i], .@ordinal$, .@changepage$);
also the .@changepage$ has to detect by HULD
.@changepage$ = _("Previous List");
| mes "Welcome ^5577FF"+strcharinfo(PC_NAME)+"^000000. We are currently having a special event for our customers."; | ||
| mes "You can get free gifts by using your ^FF5533special reserve points^000000 in the ^3355FFSpecial Kafra Gift Event^000000!!"; | ||
| mes("[Kafra]"); | ||
| mesf("Welcome ^5577FF%s^000000. We are currently having a special event for our customers.",strcharinfo(PC_NAME)); |
| mes "You have the following amount of special reserve points: ^5544FF"+RESRVPTS+"^000000."; | ||
| mes "Make a choice and test your luck!"; | ||
| mes("[Kafra]"); | ||
| mesf("You have the following amount of special reserve points: ^5544FF%d^000000.",RESRVPTS); |
There was a problem hiding this comment.
F_MesColor ...
there are a lot of places ... left
Pull Request Prelude
Changes Proposed
Affected Branches:
npc/cities/aldebaran.txt
//: # (Master? Slave?)
stable
Issues addressed:
HULD Compatibility
//: # (Issue Tracker Number if any.)
#2233
Known Issues and TODO List