-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HULD Compatibility for aldebaran.txt #2260
Conversation
…e number of enemies
- New file: effect_list.md added with markdown version of previous text document.
When player accepts invite, add them to member structure. Fixes HerculesWS#2210
this is highly discouraged, but it should still work
this will prevent further errors, and will allow setting special variables such as `#CASHPOINTS`
Also split achievement reward function to parts.
New script command: removespecialeffect *removespecialeffect(<effect number>{, <send_target>{, <unit id>{, <account id>}}}) *removespecialeffect(<effect number>{, <send_target>{, "<NPC Name>"{, <account id>}}})
this bug was introduced in eb54c76
This packet allow show camera info, or change camera parameters.
…ameters. New script commands: camerainfo, changecamera
- Changed into markdown format.
- Updated effect list based on db/constant.conf - Added Constant Name column
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is recommended that you create new branch for new PR.
As you have committed over same branch, you can see that this edit is reflected on other PR too (#2229)
May I know why it is recommended to create a new branch for a new issue ? Is it not ethical to create one branch and keep making changes to that branch only ? |
Update and fix packets up to 2018-10-02
Signed-off-by: HerculesWSAPI <dev@herc.ws>
only update zeny achievements and logs for non-zero transactions
Fixes HerculesWS#2215: Turn effect_list.txt into effect_list.md
fix setting char/account variables of another player
[github] make the pull request template less ugly
allow buildin_getd to work with constants and params
Fixed failed assertion in guild invite.
…_berserk Fixes an assertion error when sc_end is called for SC_BERSERK
Update Permission Documents
@linton-dawson |
If Item Price is 0, it is now changed to 1.
Changes the item price to 1 if it is 0
fix PACKET_ZC_PROPERTY_HOMUN size for old clients
Fixes some issues with traps
67023ed
to
029f0ce
Compare
Pull Request Prelude
Changes Proposed
Affected Branches:
stable
//: # (Master? Slave?)
Issues addressed:
npc/cities/aldebaran.txt made HULD Compatible
//: # (Issue Tracker Number if any.)
#2233
Known Issues and TODO List