Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling overlay scrollbars for a much cleaner look #691

Closed
not-a-dev-stein opened this issue Oct 10, 2021 · 0 comments
Closed

Enabling overlay scrollbars for a much cleaner look #691

not-a-dev-stein opened this issue Oct 10, 2021 · 0 comments
Labels
enhancement This feature needs upgrades. good first issue Good for newcomers.

Comments

@not-a-dev-stein
Copy link

not-a-dev-stein commented Oct 10, 2021

Is your feature request related to a problem? Please describe.
We all know that Heroic is built with Electron, so it's basically like running a Chromium instance. But that also brings the possibility of enabling chrome flags through launch options. Which is where overlay scrollbars (which were gone and then re-introduced a while back) come into play to give a much cleaner look to the interface, which, without them, looks significantly worse (in my oppinion).

Describe the solution you'd like
I'm not sure if there is other way to do so than editing the .desktop file, but it would be nice if it at least came with --enable-features=OverlayScrollbar enabled by default (enabling other flags, like SmoothScrolling would be a nice bonus for a better feel as well).

Screenshots for context
Before enabling it (and yes, I am lazily using the example screenshot from the repo):
image

After enabling it:
with-overlay-scrollbar

@flavioislima flavioislima added enhancement This feature needs upgrades. good first issue Good for newcomers. labels Oct 15, 2021
@ghost ghost self-assigned this Dec 19, 2021
flavioislima added a commit that referenced this issue Dec 22, 2021
* feat: add BE settings and types

* feat: add frontend setting toggle and handlers

* i18n: updated keys

* Fix Alt legendary binary not working #781

* feat: implement oeverlay Scrollbar #691

* chore: tests

* chore: pre-push update

* test: fix constants tests

* fix: UI fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This feature needs upgrades. good first issue Good for newcomers.
Projects
None yet
Development

No branches or pull requests

2 participants