[Fix] Several System Information improvements #3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Flatpak, `/run/host/os-release` will exist & contain the host OS' information. I intended to report this information, but missed a `break` in the loop (so it'd always find `/etc/os-release` afterwards and read that out instead)
CommandMC
added
the
pr:ready-for-review
This avoids issues with very old NVIDIA GPUs. The GPU in question was a Quadro 2000, with an ID of "0dd8". Heroic searched for just "dd8", which is not in the PCI IDs list
- Certain non-english characters aren't considered "Word characters" in Regex, so \S (any non-whitespace) is now accepted - The `free` command is ran with `LANG=C` to force English output even on non-english systems - If the match fails for any other reason, we simply return 0 bytes total/used (which is at least a valid number, even if it doesn't make sense)
When initializing Heroic's general / the game's log, we don't *have to* get system information for anything else to work; we can just report that there was an error & carry on
CommandMC
force-pushed
the
fix/sysinfo
branch
from
e8fce41
to
9e7568a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the release of 2.9.2, some issues with the new system information module were found (some major, some minor). This should iron those out
Use the following Checklist if you have changed something on the Backend or Frontend: