[Fix] Several System Information improvements

src/backend/logger/logger.ts

@@ -76,6 +76,9 @@ export function initLogger() {
         forceLog: true
       })
     })
+    .catch((error) =>
+      logError(['Failed to fetch system information', error], LogPrefix.Backend)
+    )
 
   logInfo(['Legendary location:', join(...Object.values(getLegendaryBin()))], {
     prefix: LogPrefix.Legendary,

src/backend/main.ts

@@ -978,7 +978,15 @@ ipcMain.handle(
 
     const logFileLocation = getLogFileLocation(appName)
 
-    const systemInfo = await getSystemInfo().then(formatSystemInfo)
+    const systemInfo = await getSystemInfo()
+      .then(formatSystemInfo)
+      .catch((error) => {
+        logError(
+          ['Failed to fetch system information', error],
+          LogPrefix.Backend
+        )
+        return 'Error, check general log'
+      })
     writeFileSync(logFileLocation, 'System Info:\n' + `${systemInfo}\n` + '\n')
 
     const gameSettingsString = JSON.stringify(gameSettings, null, '\t')

src/backend/utils/os/processes/index.ts

@@ -3,6 +3,7 @@ import { ChildProcess, spawn } from 'child_process'
 type SpawnWrapperOptions = Partial<{
   onStdout: (data: string, child: ChildProcess) => unknown
   onStderr: (data: string, child: ChildProcess) => unknown
+  env: Record<string, string | undefined>
 }>
 
 interface SpawnWrapperReturn {
@@ -17,7 +18,7 @@ async function genericSpawnWrapper(
   args: string[] = [],
   options: SpawnWrapperOptions = {}
 ): Promise<SpawnWrapperReturn> {
-  const child = spawn(command, args)
+  const child = spawn(command, args, { env: options?.env })
   child.stdout.setEncoding('utf-8')
   child.stderr.setEncoding('utf-8')
 

src/backend/utils/systeminfo/gpu/linux.ts

@@ -35,8 +35,8 @@ async function getGpuInfo_linux(): Promise<PartialGpuInfo[]> {
     gpus.push({
       // Electron gives us these IDs as numbers, most other use cases need
       // them as hexadecimal strings
-      deviceId: gpu.deviceId.toString(16),
-      vendorId: gpu.vendorId.toString(16),
+      deviceId: gpu.deviceId.toString(16).padStart(4, '0'),
+      vendorId: gpu.vendorId.toString(16).padStart(4, '0'),
       ...(hasLspci ? await getLspciInfo(gpu.deviceId, gpu.vendorId) : {})
     })
   }

src/backend/utils/systeminfo/memory/linux.ts

@@ -2,13 +2,15 @@ import type { PartialMemoryInfo } from './index'
 import { genericSpawnWrapper } from '../../os/processes'
 
 async function getMemoryInfo_linux(): Promise<PartialMemoryInfo> {
-  const { stdout } = await genericSpawnWrapper('free', ['-b'])
-  const match = stdout.match(/^\w*:\s*(\d*)\s*(\d*)/m)
+  const { stdout } = await genericSpawnWrapper('free', ['-b'], {
+    env: { ...process.env, LANG: 'C' }
+  })
+  const match = stdout.match(/^\S*:\s*(\d*)\s*(\d*)/m)
   const totalString = match?.[1]
   const usedString = match?.[2]
   return {
-    total: Number(totalString),
-    used: Number(usedString)
+    total: totalString ? Number(totalString) : 0,
+    used: usedString ? Number(usedString) : 0
   }
 }
 

src/backend/utils/systeminfo/osInfo/linux.ts

@@ -18,6 +18,7 @@ async function osInfo_linux(): Promise<{ name: string; version?: string }> {
     try {
       await stat(potPath)
       os_release_path = potPath
+      break
     } catch {
       // We want to ignore errors here, since we're searching for a file that may not exist
     }