Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flatpak] Update manifest for UMU support #3674

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

R1kaB3rN
Copy link
Contributor

@R1kaB3rN R1kaB3rN commented Apr 4, 2024

Related to #3480 and depends on the updated Flatpak support in ULWGL aka umu to be merged/reviewed. After the Flatpak umu is installed in the user's system, the Heroic Games Launcher will need to allow explicit access to umu's $XDG_DATA_HOME/umu and the system /app/share directory to run games through the launcher.

The reason is because, without going into the details, umu will currently copy files from /app/share to its private Flatpak directory, and Valve's Steam Runtime tools (e.g., Pressure Vessel) are designed to only be executed from the user's home directory. Without explicit visibility to these directories defined in Heroic's manifest, it's likely that umu will fail to launch games successfully due to Flatpak's strict filesystem permissions.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima
Copy link
Member

flavioislima commented Apr 4, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@R1kaB3rN
Copy link
Contributor Author

R1kaB3rN commented Apr 4, 2024

I have read the CLA Document and I hereby sign the CLA

@GloriousEggroll
Copy link

umu flatpak update has been merged:
Open-Wine-Components/umu-launcher#82

However please note this PR needs modification now as the umu-launcher manifest has been renamed from:

org.openwinecomponents.umu.launcher

to:

org.openwinecomponents.umu.umu-launcher

@flavioislima
Copy link
Member

umu flatpak update has been merged: Open-Wine-Components/umu-launcher#82

However please note this PR needs modification now as the umu-launcher manifest has been renamed from:

org.openwinecomponents.umu.launcher

to:

org.openwinecomponents.umu.umu-launcher

Thanks for the letting us know 👍🏽

@R1kaB3rN R1kaB3rN force-pushed the umu-flatpak branch 2 times, most recently from 5d1c973 to 51a5af0 Compare April 18, 2024 16:38
@arielj arielj added this to the 2.15.0 milestone Jul 13, 2024
@R1kaB3rN R1kaB3rN marked this pull request as ready for review July 14, 2024 15:35
@CommandMC
Copy link
Collaborator

I don't think the manifest kept in this repo is that relevant? It's only used when installing a local test build.
I've opened flathub/com.heroicgameslauncher.hgl#153 to add these changes to the Flathub manifest

@flavioislima flavioislima merged commit 8465488 into Heroic-Games-Launcher:main Jul 26, 2024
8 of 9 checks passed
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants