-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read laser profile from parser #1122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huixingjian
changed the title
[WIP]Read laser profile from parse
Read laser profile from parse
May 31, 2024
huixingjian
changed the title
Read laser profile from parse
Read laser profile from parser
May 31, 2024
huixingjian
changed the title
Read laser profile from parser
[WIP]Read laser profile from parser
Jun 3, 2024
huixingjian
changed the title
[WIP]Read laser profile from parser
Read laser profile from parser
Jun 7, 2024
huixingjian
changed the title
Read laser profile from parser
[WIP]Read laser profile from parser
Jun 7, 2024
huixingjian
changed the title
[WIP]Read laser profile from parser
Read laser profile from parser
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found two more places where the documentation is formatted wrong.
AlexanderSinn
added
the
component: laser envelope
About the laser envelope solver
label
Jun 26, 2024
Co-authored-by: Alexander Sinn <64009254+AlexanderSinn@users.noreply.github.com>
Co-authored-by: Alexander Sinn <64009254+AlexanderSinn@users.noreply.github.com>
AlexanderSinn
approved these changes
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the laser profile can be initialised through parser, with
lasers.laser_real(x,y,z)=" "
for real part andlasers.laser_imag(x,y,z)=" "
for imaginary part separately.