-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make from_file and other laser init compatible #1144
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huixingjian
changed the title
Make from_file and other laser init compatible
[WIP]Make from_file and other laser init compatible
Aug 2, 2024
huixingjian
changed the title
[WIP]Make from_file and other laser init compatible
Make from_file and other laser init compatible
Aug 2, 2024
With the input of
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to fix the confliction that no user-defined laser could be generated when reading laser from file.
Combining with PR #1122 and PR #866, the code can now initialise multiple lasers by parser\gaussian\from_file.
-The default option of
<laser name>. init_type
would begaussian
. And another two options areparser
from_file
.Note that the central wavelength of all the lasers ought to be identical on current setting. An error will be raised if the value of
lasers.lambda0
doesn't equal to the wavelength loaded from file.