Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read in Laser form OpenPMD file #866

Merged
merged 6 commits into from
Mar 1, 2023

Conversation

AlexanderSinn
Copy link
Member

@AlexanderSinn AlexanderSinn commented Feb 10, 2023

Add capability to read in a laser envelope openPMD file genrated by LASY

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

Sorry, something went wrong.

@AlexanderSinn AlexanderSinn added the component: laser envelope About the laser envelope solver label Feb 10, 2023
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! See a few comments below.

docs/source/run/parameters.rst Outdated Show resolved Hide resolved
src/laser/MultiLaser.H Outdated Show resolved Hide resolved
src/laser/MultiLaser.H Outdated Show resolved Hide resolved
src/laser/MultiLaser.cpp Show resolved Hide resolved
src/laser/MultiLaser.cpp Outdated Show resolved Hide resolved
src/laser/MultiLaser.H Outdated Show resolved Hide resolved
src/laser/MultiLaser.cpp Outdated Show resolved Hide resolved
src/laser/MultiLaser.cpp Outdated Show resolved Hide resolved
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: laser envelope About the laser envelope solver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants